Skip to content

Commit

Permalink
REF: Remove rolling window fixed algorithms (#36567)
Browse files Browse the repository at this point in the history
* Fix rolling test result, removed fixed algorithms, some rolling apply with center tests still failing

* Rename function and move offset to correct location

* Impliment center in terms of indexers

* Get all the tests to pass

* Remove center from _apply as no longer needed

* Add better typing

* Deal with numeric precision

* Remove code related to center now being implimented in the fixed indexer

* Add note regarding precision issues

* Note performance hit

* Remove tilde

* Change useage of get_cython_func_type

* Remove self.center from count's _apply

Co-authored-by: Matt Roeschke <mroeschke@housecanary.com>
  • Loading branch information
mroeschke and Matt Roeschke authored Oct 9, 2020
1 parent 31ae9a5 commit 846cff9
Show file tree
Hide file tree
Showing 6 changed files with 84 additions and 494 deletions.
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.2.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ Performance improvements
- The internal index method :meth:`~Index._shallow_copy` now makes the new index and original index share cached attributes,
avoiding creating these again, if created on either. This can speed up operations that depend on creating copies of existing indexes (:issue:`36840`)
- Performance improvement in :meth:`RollingGroupby.count` (:issue:`35625`)
- Small performance decrease to :meth:`Rolling.min` and :meth:`Rolling.max` for fixed windows (:issue:`36567`)

.. ---------------------------------------------------------------------------
Expand Down
Loading

0 comments on commit 846cff9

Please sign in to comment.