Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: nlargest/nsmallest, take_last -> keep #10792

Closed
jreback opened this issue Aug 10, 2015 · 2 comments
Closed

API: nlargest/nsmallest, take_last -> keep #10792

jreback opened this issue Aug 10, 2015 · 2 comments
Labels
API Design Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Milestone
0.17.0

Comments

@jreback
Copy link
Contributor

jreback commented Aug 10, 2015

nlargest/nsmallest on frame should have take_last -> keep, in-line with #10236

here

no deprecation is necessary as this is new in 0.17.0

cc @sinhrks
cc @cpcloud
@jreback jreback added Reshaping Concat, Merge/Join, Stack/Unstack, Explode API Design labels Aug 10, 2015
@jreback jreback added this to the 0.17.0 milestone Aug 10, 2015
@sinhrks
Copy link
Member

sinhrks commented Aug 11, 2015

Do we need an option to keep all elements in this case, keep='all' or keep=True?

And Series.nlargest/nsmallest need deprecation.

@jreback
Copy link
Contributor Author

jreback commented Aug 11, 2015

you don't need to keep all option (that would be just sort :)

so just a direct keyword replacement for Series

@sinhrks sinhrks mentioned this issue Aug 28, 2015
Merged
@jsexauer jsexauer mentioned this issue Aug 29, 2015
Closed
1 task
gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 16, 2017
@gfyoung
Drop take_last kwarg from method signatures
d110ec7 
Affected methods:

1) nlargest
2) nsmallest
3) duplicated
4) drop_duplicates

xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 16, 2017
@gfyoung
Drop take_last kwarg from method signatures
30372eb 
Affected methods:

1) nlargest
2) nsmallest
3) duplicated
4) drop_duplicates

xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 17, 2017
@gfyoung
Drop take_last kwarg from method signatures
14da6e6 
Affected methods:

1) nlargest
2) nsmallest
3) duplicated
4) drop_duplicates

xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 17, 2017
@gfyoung
MAINT: Drop take_last kwarg from method signatures
d285298 
Affected methods:

1) nlargest
2) nsmallest
3) duplicated
4) drop_duplicates

xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
@gfyoung gfyoung mentioned this issue Mar 17, 2017
Closed
gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 17, 2017
@gfyoung
MAINT: Drop take_last kwarg from method signatures
f4b329d 
Affected methods:

1) nlargest
2) nsmallest
3) duplicated
4) drop_duplicates

xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 17, 2017
@gfyoung
MAINT: Drop take_last kwarg from method signatures
19998be 
Affected methods:

1) nlargest
2) nsmallest
3) duplicated
4) drop_duplicates

xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
@jreback jreback mentioned this issue Mar 17, 2017
Closed
gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 17, 2017
@gfyoung
MAINT: Drop take_last kwarg from method signatures
8997613 
Affected methods:

1) nlargest
2) nsmallest
3) duplicated
4) drop_duplicates

xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 17, 2017
@gfyoung
MAINT: Drop take_last kwarg from method signatures
c72cffe 
Affected methods:

1) nlargest
2) nsmallest
3) duplicated
4) drop_duplicates

xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 17, 2017
@gfyoung
MAINT: Drop take_last kwarg from method signatures
b416290 
Affected methods:

1) nlargest
2) nsmallest
3) duplicated
4) drop_duplicates

xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
jreback pushed a commit that referenced this issue Mar 18, 2017
@gfyoung @jreback
MAINT: Drop take_last kwarg from method signatures
a9c8239 
Affected methods:

1) nlargest
2) nsmallest
3) duplicated
4) drop_duplicates

xref #10236, #10792, #10920.

Author: gfyoung <gfyoung17@gmail.com>

Closes #15710 from gfyoung/create-last-kw-drop and squashes the following commits:

b416290 [gfyoung] MAINT: Drop take_last kwarg from method signatures
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
@gfyoung @AnkurDedania
MAINT: Drop take_last kwarg from method signatures
eefe266 
Affected methods:

1) nlargest
2) nsmallest
3) duplicated
4) drop_duplicates

xref pandas-dev#10236, pandas-dev#10792, pandas-dev#10920.

Author: gfyoung <gfyoung17@gmail.com>

Closes pandas-dev#15710 from gfyoung/create-last-kw-drop and squashes the following commits:

b416290 [gfyoung] MAINT: Drop take_last kwarg from method signatures
mattip pushed a commit to mattip/pandas that referenced this issue Apr 3, 2017
@gfyoung @mattip
MAINT: Drop take_last kwarg from method signatures
8b6a9a2 
Affected methods:

1) nlargest
2) nsmallest
3) duplicated
4) drop_duplicates

xref pandas-dev#10236, pandas-dev#10792, pandas-dev#10920.

Author: gfyoung <gfyoung17@gmail.com>

Closes pandas-dev#15710 from gfyoung/create-last-kw-drop and squashes the following commits:

b416290 [gfyoung] MAINT: Drop take_last kwarg from method signatures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
2 participants
@jreback @sinhrks