Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: cleanup bench / scripts #13704

Closed
5 of 6 tasks
jreback opened this issue Jul 19, 2016 · 7 comments · Fixed by #18181
Closed
5 of 6 tasks

CLN: cleanup bench / scripts #13704

jreback opened this issue Jul 19, 2016 · 7 comments · Fixed by #18181

Comments

@jreback
Copy link
Contributor

jreback commented Jul 19, 2016

now that we removed sandbox in #13670, some scripts remain that use this.

  • I think we could fully remove the bench sub-dir, taking care if we don't have asv's for anything there (I think we do but need to check). (PR CLN/COMPAT: for various py2/py3 in doc/bench scripts #16984)
  • scripts dir, we can blow windows_builder (PR CLN/COMPAT: for various py2/py3 in doc/bench scripts #16984)
  • scripts dir, we can blow away most of these with the exception of: api_rst_coverage.py, find_undoc_args.py, merge-py.py, find_commits_touching_func.py, again checking for any benchmark scripts and make sure we have asv.
  • add README.md for scripts that documents purpose of these scripts
  • move pandas/build_dist.sh and pandas/release_stats.sh to scripts (need to updat e commit checklist though and slightly modify).
  • remove pandas/test_perf.sh and pandas/Makefile
@jreback
Copy link
Contributor Author

jreback commented Jul 19, 2016

cc @jorisvandenbossche

@jorisvandenbossche
Copy link
Member

+1 for a clean-up. I think we can also remove the vb_suite? (just need to look back at the conversion PR to see if some parts didn't get converted)

For the bench dir, indeed need to check if there is content that could be moved to asv. Only the python vs R benchmarks would not be suited for that, but I am not sure if we have to keep that in the pandas repo.

I also want to clean-up the auto-converted asv bench (now a lot of duplicated setup things, which makes it difficult to get an overview of that)

@jorisvandenbossche
Copy link
Member

Also the test_perf.sh can be removed.

Do you actually use the Makefile?

@jreback
Copy link
Contributor Author

jreback commented Jul 19, 2016

yes test_perf.sh can go. the Makefile I actually do use it, but no real objection to removing it; we use python setup.py build_ext --inplace is the default anyhow (and the Makefile doesn't work on windows).

@sinhrks
Copy link
Member

sinhrks commented Jul 19, 2016

wiki needs to be updated also:

@jorisvandenbossche
Copy link
Member

@jreback no, it's fine to keep Makefile if people use it (I use bashrc aliases for shortcuts for those things)

@sinhrks I think that wiki page can just be deleted (or, should check if there is still any explanatory content that can be moved to contributing.rst)

@jorisvandenbossche
Copy link
Member

I already did part of this locally, but removing it from 0.19.0 milestone as it is not a blocker

@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, 0.19.0 Aug 13, 2016
@jreback jreback modified the milestones: 0.20.0, Next Major Release Mar 23, 2017
@jreback jreback modified the milestones: Next Major Release, 0.22.0 Nov 8, 2017
jreback added a commit to jreback/pandas that referenced this issue Nov 8, 2017
jreback added a commit that referenced this issue Nov 9, 2017
watercrossing pushed a commit to watercrossing/pandas that referenced this issue Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this issue Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants