Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS formating for deprecated parameters / methods #20349

Closed
TomAugspurger opened this issue Mar 14, 2018 · 6 comments · Fixed by #20357
Closed

Add CSS formating for deprecated parameters / methods #20349

TomAugspurger opened this issue Mar 14, 2018 · 6 comments · Fixed by #20357

Comments

@TomAugspurger
Copy link
Contributor

These aren't especially noticeable in the HTML docs.

screen shot 2018-03-14 at 1 13 58 pm

Adding this to our CSS should fix that

div.deprecated {
    background-color: #ffe4e4;
    border: 1px solid #f66;
}

cc @datapythonista @shoyer

@TomAugspurger
Copy link
Contributor Author

@Imanflow
Copy link
Contributor

I would like to take this as my first contribution.

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Mar 14, 2018

👍 thanks.

I think if you modify the CSS file then run

# in pandas/doc
python make.py --single=pandas.DataFrame.from_csv

you should be able to validate the output quickly.

@Imanflow
Copy link
Contributor

i follow the intructions from https://pandas.pydata.org/pandas-docs/stable/contributing.html#where-to-start
until git checkout -b shiny-new-feature. I did the change in the file, but this step git fetch upstream, it says upstream is not a repository. I tried git fetch pandas, but it didnt work either.

Regarding python make.py --single=pandas.DataFrame.from_csv,

error message ImportError: dateutil 2.5.0 is the minimum required version despite i installed python-dateutil v==4.0.0

I'm sorry for my inexpertise

@TomAugspurger
Copy link
Contributor Author

What's git remote -v?

May have to add pandas-dev/pandas as a remote

git remote add upstream https://github.com/pandas-dev/pandas

Not sure about the dateutil error. Did you make an environment for pandas? Did you activate it?

@Imanflow
Copy link
Contributor

I started the process again, and everything worked fine.

Here is the pull request: #20357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants