Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Unify compression-kwarg for IO-methods #21640

Closed
h-vetinari opened this issue Jun 26, 2018 · 3 comments
Closed

API: Unify compression-kwarg for IO-methods #21640

h-vetinari opened this issue Jun 26, 2018 · 3 comments
Labels
API - Consistency Internal Consistency of API/Behavior IO Data IO issues that don't fit into a more specific label

Comments

@h-vetinari
Copy link
Contributor

Currently, there's:

  • 'compression' in to_csv, to_json, to_parquet, to_pickle
  • 'complib' in to_hdf (also 'complevel')
  • 'compress' in to_msgpack

Those are all the writer-methods from https://pandas.pydata.org/pandas-docs/version/0.23.1/io.html which have compression.

Seems to me that the kwargs of to_hdf and to_msgpack should be unified with the other methods.
@gfyoung gfyoung added IO Data IO issues that don't fit into a more specific label API Design labels Jun 27, 2018
@gfyoung
Copy link
Member

gfyoung commented Jun 27, 2018

@jreback : This sounds very similar to #15862.

@h-vetinari
Copy link
Contributor Author

@gfyoung Didn't know that PR, thanks. It has a much larger scope than this one - I just stumbled over this inconsistency when benchmarking several IO methods.

@h-vetinari h-vetinari mentioned this issue Nov 18, 2018
Closed
@h-vetinari h-vetinari mentioned this issue Jan 28, 2019
Closed
@WillAyd WillAyd mentioned this issue Jun 2, 2019
Closed
@jbrockmendel jbrockmendel added API - Consistency Internal Consistency of API/Behavior and removed API Design labels Dec 19, 2019
@mroeschke
Copy link
Member

I think the the compression points are covered in #15008 which seems to be our overarching IO consolidation issue. Going to close in favor of that issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API - Consistency Internal Consistency of API/Behavior IO Data IO issues that don't fit into a more specific label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jbrockmendel @gfyoung @mroeschke @h-vetinari