Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: deprecate pandas/io/date_converters.py #24518

Closed
mroeschke opened this issue Dec 31, 2018 · 7 comments · Fixed by #35741
Closed

DEPR: deprecate pandas/io/date_converters.py #24518

mroeschke opened this issue Dec 31, 2018 · 7 comments · Fixed by #35741
Assignees
Labels
Datetime Datetime data dtype Deprecate Functionality to remove in pandas good first issue IO CSV read_csv, to_csv
Milestone

Comments

@mroeschke
Copy link
Member

This file contains one function that is used elsewhere in the code base (that can be moved), and the rest is unused and not advertised in the api.

Raising this issue to gauge whether we should outright remove it or deprecate this file since its technically public in io

@jreback
Copy link
Contributor

jreback commented Jan 1, 2019

yeah let's do it. I also think you can just remove the generic_parser branch entirely (meaning just fully deprecate this), I think to_datetime handles all of these cases

@jreback jreback added Datetime Datetime data dtype IO CSV read_csv, to_csv Deprecate Functionality to remove in pandas labels Jan 1, 2019
@jorisvandenbossche
Copy link
Member

Yes, I think the original idea behind this was to have functions that could be passed to read_csv's date_parser function. But there are much better ways to do that (to_datetime, or a way to provide a date format in read_csv that is discussed elsewhere).
So happy to see it deprecated

@jbrockmendel
Copy link
Member

definitely go for it.

@jorisvandenbossche jorisvandenbossche added this to the Contributions Welcome milestone Dec 11, 2019
@jbrockmendel
Copy link
Member

Is any of this user-facing (i.e.need deprecation cycle) or can we just rip it out?

@mroeschke
Copy link
Member Author

The conservative thing to do is go through a deprecation cycle, but since this is not advertised anywhere ripping it out might be okay.

@jorisvandenbossche
Copy link
Member

This is documented (https://dev.pandas.io/docs/user_guide/io.html#date-parsing-functions), so certainly needs to be deprecated first I think

@jorisvandenbossche jorisvandenbossche changed the title Remove/Deprecate(?) pandas/io/date_converters.py DEPR: deprecate pandas/io/date_converters.py Dec 21, 2019
@avinashpancham
Copy link
Contributor

take

@jreback jreback modified the milestones: Contributions Welcome, 1.2 Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Deprecate Functionality to remove in pandas good first issue IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants