DEPR: Deprecate pandas/io/date_converters.py #35741
Conversation
avinashpancham
changed the title
There was a problem hiding this comment.
so you are deprecating, changing the impl and removing the tests. I am ok with this if you don't remove any tests (and just assert the warnings). otherwise its very hard to tell if things still work as before (which defeats the point of deprecation). i am also ok with leaving the impl completely (though your changes do clean up).
jreback
added
Deprecate
|
@jreback addressed all your comments. Could you have a second look? |
|
this looks good can you merge master and ping on green. |
…precate_date_converters
|
@jreback merged master; all checks in CI pass except two, due to a flaky test (see below)
|
|
Reran CI, now everything passes |
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -195,7 +195,7 @@ Deprecations | |||
| ~~~~~~~~~~~~ | |||
| - Deprecated parameter ``inplace`` in :meth:`MultiIndex.set_codes` and :meth:`MultiIndex.set_levels` (:issue:`35626`) | |||
| - Deprecated parameter ``dtype`` in :~meth:`Index.copy` on method all index classes. Use the :meth:`Index.astype` method instead for changing dtype(:issue:`35853`) | |||
| - | |||
| - Date parser functions :func:`parse_date_time`, :func:`parse_date_fields`, :func:`parse_all_fields` and :func:`generic_parser` from ``pandas.io.date_converters`` are deprecated and will be removed in a future version; use pandas.to_datetime() instead (GH35741) | |||
There was a problem hiding this comment.
can you put in :func:`to_datetime` so it renders all of the others won't render at all i think (e.g. :func:`parse_date_time` . so those should be updated to a fully qualified path (e.g. pandas.io.date_converters)
|
@jreback updated doc, merged master and CI on green |
|
thanks @avinashpancham very nice! |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff