Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN/TST: move consoliate sort_index to core/generic.py #8283

Closed
jreback opened this issue Sep 16, 2014 · 2 comments · Fixed by #36177
Closed

CLN/TST: move consoliate sort_index to core/generic.py #8283

jreback opened this issue Sep 16, 2014 · 2 comments · Fixed by #36177
Labels
API Design Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Milestone
1.2

Comments

@jreback
Copy link
Contributor

jreback commented Sep 16, 2014

xref #8282
xref #8239 (this issue won't touch the API per se)

expand extend: core/generic.py/NDFrame.sort_index: https://github.com/pydata/pandas/blob/master/pandas/core/generic.py#L1606

with the frame version.
https://github.com/pydata/pandas/blob/master/pandas/core/frame.py#L2689

needs generic docs (e.g. look how reindex is done)

as prob best to start with the frame version that handles ndim=2. Need tests for added capabilities to Series/Panel, e.g. mainly supporting sort_index on a multi-level index.
@jreback jreback added Refactor Internal refactoring of code Good as first PR API Design Internals Related to non-user accessible pandas implementation labels Sep 16, 2014
@jreback jreback added this to the 0.16 milestone Sep 16, 2014
@jreback jreback mentioned this issue Sep 19, 2014
Closed
@jreback jreback modified the milestones: 0.16, 0.15.1 Oct 7, 2014
@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 6, 2015
@chrisaycock
Copy link
Contributor

DataFrame.sort_index() has a deprecated by parameter. This parameter doesn't even exist in Series or NDFrame. Is it ok to just remove this altogether?

@jreback
Copy link
Contributor Author

jreback commented Feb 27, 2016

so what you can do is provide the impl in core/generic.py, then for DataFrame provide the current signature (with the by depr message as is), and just call super.

@jreback jreback modified the milestones: Next Major Release, Next Minor Release Mar 29, 2017
@jreback jreback modified the milestones: Interesting Issues, Next Major Release Nov 26, 2017
@datapythonista datapythonista modified the milestones: Contributions Welcome, Someday Jul 8, 2018
fangchenli added a commit to fangchenli/pandas that referenced this issue Sep 6, 2020
@fangchenli
CLN: move sort_index to core/generic.py pandas-dev#8283
12dafcf
fangchenli added a commit to fangchenli/pandas that referenced this issue Sep 6, 2020
@fangchenli
CLN: ignore typing check in core/generic.py pandas-dev#8283
c2e2cb3
@fangchenli fangchenli mentioned this issue Sep 6, 2020
Merged
3 tasks
fangchenli added a commit to fangchenli/pandas that referenced this issue Sep 7, 2020
@fangchenli
CLN: remove unused import pandas-dev#8283
909fec6
@jreback jreback modified the milestones: Someday, 1.2 Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Move sort index to generic fangchenli/pandas
4 participants
@chrisaycock @jreback @TomAugspurger @datapythonista