Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add Series.astype with the new tz dtype #11003

Merged
merged 2 commits into from
Sep 7, 2015
Merged

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Sep 5, 2015

add ability to astype using the new dtype

@jreback jreback added this to the 0.17.0 milestone Sep 5, 2015
@jorisvandenbossche
Copy link
Member

@jreback I am not really sure about this. For me, it is not very clear if this would be doing a tz_convert or a tz_localize.

And since we already have tz_convert and tz_localize, I don't really see the added value of advertising the use of astype('datetime64[ns, tz=...]') as an alternative

@jreback
Copy link
Contributor Author

jreback commented Sep 5, 2015

@jorisvandenbossche is just for compat really. I think people would try to do it. its actually very natural once you try it! (think about tz as part of the dtype, then this makes perfect sense).

@jreback
Copy link
Contributor Author

jreback commented Sep 5, 2015

and we allow s_aware.astype('datetime64[ns]') so this is just the other direction

jreback added a commit that referenced this pull request Sep 7, 2015
ENH: add Series.astype with the new tz dtype
@jreback jreback merged commit 953e66a into pandas-dev:master Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants