Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: to_latex() output broken when the index has a name (GH10660) #11233

Merged

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Oct 4, 2015

closes #10660

first try at contributing to pandas. feedbacks will be greatly appreciated.

@taeold taeold changed the title BUG: to_latex() output broken when the index has a name #10660 BUG: to_latex() output broken when the index has a name (GH10660) Oct 4, 2015
@jreback jreback added Bug Output-Formatting __repr__ of pandas objects, to_string IO LaTeX to_latex labels Oct 4, 2015
@@ -2648,6 +2648,23 @@ def test_to_latex_multiindex(self):
"""
self.assertEqual(result, expected)

df = pd.DataFrame({'a':[0,0,1,1], 'b':list('abab'), 'c':[1,2,3,4]})
df = df.set_index(['a', 'b'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also provide a test using the groupby in the issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@jreback jreback added this to the 0.17.1 milestone Oct 5, 2015
@jreback
Copy link
Contributor

jreback commented Oct 5, 2015

looks good. pls squash.

@@ -2648,6 +2648,49 @@ def test_to_latex_multiindex(self):
"""
self.assertEqual(result, expected)

df = pd.DataFrame({'a':[0,0,1,1], 'b':list('abab'), 'c':[1,2,3,4]})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the issue number here as a comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do - thanks for the review

@taeold taeold force-pushed the bugfix/multiindex-frame-to-latex-bug branch from 72a7368 to f5efd3b Compare October 5, 2015 15:55
jreback added a commit that referenced this pull request Oct 9, 2015
…x-bug

BUG: to_latex() output broken when the index has a name (GH10660)
@jreback jreback merged commit b24d81d into pandas-dev:master Oct 9, 2015
@jreback
Copy link
Contributor

jreback commented Oct 9, 2015

thank you sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug IO LaTeX to_latex Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: to_latex() output broken when the index has a name
2 participants