ENH/PERF SparseArray.take indexing #12796
Closed
+567
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Testing
| @@ -307,13 +316,14 @@ def _get_val_at(self, loc): | |||
| else: | |||
| return _index.get_value_at(self, sp_loc) | |||
|
|
|||
| def take(self, indices, axis=0): | |||
There was a problem hiding this comment.
maybe use the shared_docs here?
| ind_val = indexer[i] | ||
| if ind_val < 0 or self.length <= ind_val: | ||
| results[i] = -1 | ||
| else: |
There was a problem hiding this comment.
I think you need to filter first, then call:
inds.searchsorted(indices_to_find) IOW it takes an array as an input (and outputs and array).
There was a problem hiding this comment.
@jreback thanks, changed to vectorized version.
sinhrks
force-pushed
the
sparse_test_at
branch
2 times, most recently
from
95de480
to
33829a0
Compare
|
@jreback rebased, and now green. |
| if allow_fill and fill_value is not None: | ||
| # allow -1 to indicate self.fill_value, | ||
| # self.fill_value may not be NaN | ||
| if (indices < -1).any(): |
There was a problem hiding this comment.
so if you can make an issue at some point we can move this stuff (and combin with the guts of assert_fillable_take as an internal function in core/algorighthms.py, but ok for now.
|
thanks @sinhrks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SparseDataFrameindexing test is not sufficient)git diff upstream/master | flake8 --diffAdded more tests for sparse indexing. Fixed followings:
SparseArray.takehas optimized logic to omit densenp.ndarraycreation.SparseSeires.iloccan work with negative indices. MadeSparseArray.taketo handle negative indices as the same rule asIndex(API: Index.take inconsistently handle fill_value #12676)