Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPAT: Expand compatibility with fromnumeric.py #12810

Closed
wants to merge 1 commit into from
Closed

COMPAT: Expand compatibility with fromnumeric.py #12810

wants to merge 1 commit into from

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Apr 6, 2016 •
edited
Loading

Fixes up OR addresses what are AFAICT almost if not all of the incompatibilities pandas currently has with numpy.core.fromnumeric. My goodness, were there a lot of them.

Closes #12638.
Closes #12644.
Closes #12687.

This was referenced Apr 6, 2016
Closed
Closed
Closed
Closed
@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Apr 6, 2016
@jreback jreback added this to the 0.18.1 milestone Apr 6, 2016
@jreback
Copy link
Contributor

jreback commented Apr 6, 2016

ok, some comments.

jreback
jreback reviewed Apr 6, 2016
View reviewed changes
doc/source/whatsnew/v0.18.1.txt
@@ -105,6 +104,56 @@ API changes
- ``pd.show_versions()`` now includes ``pandas_datareader`` version (:issue:`12740`)
- Provide a proper ``__name__`` and ``__qualname__`` attributes for generic functions (:issue:`12021`)

.. _whatsnew_0181.numpy_compatibility

Compatibility between pandas array-like methods (e.g. ```sum`` and ``take``) and their analogous
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

say numpy counterparts, rather than analagous

dont need (generally with *args, and **kwargs).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@gfyoung gfyoung mentioned this pull request Apr 6, 2016
Closed
@gfyoung gfyoung force-pushed the fromnumeric-compat branch 2 times, most recently from f1d02ed to 365f956 Compare April 6, 2016 13:35
gfyoung
gfyoung reviewed Apr 6, 2016
View reviewed changes
pandas/core/generic.py
Do not call this function via the numpy library, as numpy's version
has a completely different purpose (returns number of dimensions in
an array)!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback : How about this warning? Should it be kept, or should it be the user's responsibility to know the two 'rank' functions serve completely different purposes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a really different signature as pandas rank is much more friendly to different dtypes, you can prob just raise on this one if someone does np.rank(...) but if you can't it doesn't really matter. again if someone is doing it, then they must know what they are doing, no amount of documentation will help.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I think I'll just remove it then. In worst case, if a user tries to call via the numpy library we can say that, "look, the documentation is different".

@gfyoung gfyoung force-pushed the fromnumeric-compat branch 3 times, most recently from fb61e17 to b809c2a Compare April 6, 2016 21:22
@wesm
Copy link
Member

wesm commented Apr 6, 2016

I hate to be a curmudgeon on this issue, but how do we benefit from increasing our API coupling to NumPy? We've been discussing moving precisely in the opposite direction.

@gfyoung gfyoung force-pushed the fromnumeric-compat branch 3 times, most recently from 427a54b to 10fb3ae Compare April 30, 2016 01:20
@gfyoung
Copy link
Member Author

gfyoung commented Apr 30, 2016

I've made all of the necessary changes (for ones I didn't make I provided reason(s) for not doing so), and Travis is still passing. Codecov is doing something strange as it is with my test_parsers PR.

jreback
jreback reviewed Apr 30, 2016
View reviewed changes
pandas/sparse/tests/test_array.py

data[5] = np.nan
out = np.cumsum(SparseArray(data, fill_value=2))
self.assertNotIsInstance(out, SparseArray)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same reference here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same response as above

@jreback jreback added this to the 0.18.1 milestone Apr 30, 2016
@jreback
Copy link
Contributor

jreback commented Apr 30, 2016

@gfyoung ok just a couple minor comments. pls rebase and lmk when green. also your numpy side-pr won't cause any issues (as it will be merged to numpy after this)?

@jreback
Copy link
Contributor

jreback commented Apr 30, 2016

ok, I think this looks good. give a nice update / rebase and force push. ping when green.

@gfyoung
COMPAT: Expand compatibility with fromnumeric.py
429bc51 
Augment pandas array-like methods with appropriate parameters
(generally, '*args' and '**kwargs') so that they can be called
via analogous functions in the numpy library they are defined in
'fromnumeric.py'.

Closes pandas-devgh-12638.
Closes pandas-devgh-12644.
Closes pandas-devgh-12687.
@gfyoung
Copy link
Member Author

gfyoung commented May 1, 2016

@jreback : Travis is giving the green light. Ready to merge if there is nothing else.

@jreback jreback mentioned this pull request May 1, 2016
Closed
@jreback jreback closed this in 23eb483 May 1, 2016
@jreback
Copy link
Contributor

jreback commented May 1, 2016

thanks @gfyoung that was beast-like !

@gfyoung
Copy link
Member Author

gfyoung commented May 1, 2016

Sure thing. 😄

@gfyoung gfyoung deleted the fromnumeric-compat branch May 1, 2016 15:15
@gfyoung gfyoung mentioned this pull request May 12, 2016
Closed
jreback pushed a commit that referenced this pull request May 20, 2016
@gfyoung @jreback
COMPAT: Further Expand Compatibility with fromnumeric.py
fecb2ca 
Follow-on to #12810 by expanding compatibility with fromnumeric.py
in the following modules:
  1) tslib.pyx
  2) window.py
  3) groupby.py and resample.py (shared classes)

Closes #12811.

Author: gfyoung <gfyoung17@gmail.com>

Closes #13148 from gfyoung/fromnumeric-compat-continued and squashes the following commits:

eb4762c [gfyoung] COMPAT: Expand compatibility with fromnumeric.py
@jreback jreback mentioned this pull request May 31, 2016
Closed
@hemangjoshi37a
Copy link

Please pull this solution to main library of pandas because still this problem is not solved...

@jorisvandenbossche
Copy link
Member

@hemangjoshi37a this changeset is already included in the main pandas library since the 0.18.1 release. If you still have a problem related to this, please open a new issue with a reproducible example.

@hemangjoshi37a
Copy link

hemangjoshi37a commented Jun 28, 2018 via email

@gfyoung gfyoung mentioned this pull request Apr 2, 2019
Closed
@rhshadrach rhshadrach mentioned this pull request Jun 4, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
0.18.1
Development

Successfully merging this pull request may close these issues.
6 participants
@gfyoung @jreback @wesm @codecov-io @hemangjoshi37a @jorisvandenbossche