Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: GroupBy with TimeGrouper sorts unstably #12840

Closed
wants to merge 1 commit into from
Closed

BUG: GroupBy with TimeGrouper sorts unstably #12840

wants to merge 1 commit into from

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Apr 9, 2016

Because it may affect to resample perf, alternative idea is to add TimeGropuper path to GroupBy.first and last.

@sinhrks sinhrks added this to the 0.18.1 milestone Apr 9, 2016
@sinhrks sinhrks mentioned this pull request Apr 9, 2016
Closed
@jreback
Copy link
Contributor

jreback commented Apr 9, 2016

hmm, ok, can you add a tests specifically for this sorting differential?

@sinhrks
Copy link
Member Author

sinhrks commented Apr 10, 2016

Yep, added tests using get_group.

@jreback jreback closed this in ea9a5a8 Apr 10, 2016
@sinhrks sinhrks deleted the tgrouper_first branch April 10, 2016 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Groupby
Projects
None yet
Milestone
0.18.1
Development

Successfully merging this pull request may close these issues.

BUG: Unable to aggregate TimeGrouper
2 participants
@sinhrks @jreback