ENH: add .resample(..).interpolate() #12925 #12974
Conversation
| @Appender(_shared_docs['interpolate'] % _shared_docs_kwargs) | ||
| def interpolate(self, method='linear', axis=0, limit=None, inplace=False, | ||
| limit_direction='forward', downcast=None, **kwargs): | ||
| tmp = self._upsample(None, limit=limit) |
There was a problem hiding this comment.
don't pass limit here, its handled in interpolate
jreback
added
Enhancement
Missing-data
|
|
||
| import pandas as pd | ||
| import pandas.compat as compat | ||
| import pandas.core.algorithms as algos |
There was a problem hiding this comment.
pls don't move things around uncessariliy.
|
minor doc-change. pls squash as well. |
|
ping when green. |
|
thanks! |
| limit_direction='forward', downcast=None, **kwargs): | ||
| """ | ||
| .. versionadded:: 0.18.1 | ||
| ``.resample(..).interpolate()`` is now supported (:issue:`12925`) |
There was a problem hiding this comment.
Putting this here in the beginning of the docstring does not really work well I think. Because the rest (the shared_docs['interpolate']) are appended, the explanation starts with 'versionadded', while it should rather be "Interpolate values according to different methods" (although, as long as it is not listed in an API overview, it is not really that big of a problem. But, it should actually be added here:http://pandas-docs.github.io/pandas-docs-travis/api.html#upsampling)
|
@jorisvandenbossche ahh, ok, let me fix that. |
|
Thanks for your help too! |
These tests simply check that df.resample(...).mean().interpolate() gives the same result than df.resample(...).interpolate()
git diff upstream/master | flake8 --diff-> Edit: 24/04/2016 20:25