BUG: fix to_records confict with unicode_literals #13172 #13178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls add the test from the issue & a whats new (bug fix) |
jreback
added
Unicode
| def test_to_records_with_unicode_index(self): | ||
| res = DataFrame([{u'a': u'x', u'b': 'y'}]).set_index(u'a').to_records() | ||
| expect_res = np.rec.array([('x', 'y')], dtype=[('a', 'O'), ('b', 'O')]) | ||
| self.assertEqual(res, expect_res) |
There was a problem hiding this comment.
use
result = ....
expected = ....
tm.assert_numpy_array_equal(result, expected)
use tm.assert_numpy_array_equal here (and only need 1 assert; that will compare everything)
add the issue number as a comment
|
lgtm. minor test change; ping when green. |
|
done. lgtm. minor test change; ping when green. |
|
thanks @starplanet nice patch! |
jreback
added a commit
that referenced
this pull request
May 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff