DEPR: Remove legacy offsets #13590
Closed
DEPR: Remove legacy offsets #13590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
force-pushed
the
depr_legacy_offset
branch
from
aa7871c
to
7d0d674
Compare
| @@ -432,6 +432,7 @@ Deprecations | |||
| - ``buffer_lines`` has been deprecated in ``pd.read_csv()`` and will be removed in a future version (:issue:`13360`) | |||
| - ``as_recarray`` has been deprecated in ``pd.read_csv()`` and will be removed in a future version (:issue:`13373`) | |||
| - top-level ``pd.ordered_merge()`` has been renamed to ``pd.merge_ordered()`` and the original name will be removed in a future version (:issue:`13358`) | |||
| - Removal of the legacy time rules (offset aliases), deprecated since 0.14.0 (this has been alias since 0.8.0) (GH13590). | |||
There was a problem hiding this comment.
put in a top-level separate section (prior deprecation removal - look how I did this for 0.18.0)
1 task
Current coverage is 84.39%@@ master #13590 diff @@
==========================================
Files 142 142
Lines 51225 51191 -34
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43225 43202 -23
+ Misses 8000 7989 -11
Partials 0 0
|
sinhrks
force-pushed
the
depr_legacy_offset
branch
from
7d0d674
to
59d3984
Compare
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| - Removal of the legacy time rules (offset aliases), deprecated since 0.14.0 (this has been alias since 0.8.0) (GH13590). | ||
|
|
There was a problem hiding this comment.
put the issue reference as a link
There was a problem hiding this comment.
I would also add a blurb about what exactly these are (show an example), and point to the new docs as well.
There was a problem hiding this comment.
oops, changed the issue number to the link.
|
lgtm otherwise. |
sinhrks
force-pushed
the
depr_legacy_offset
branch
2 times, most recently
from
4c295e4
to
b554bc7
Compare
|
The "Removal of prior version deprecations/changes" section has already been added in the meantime, so I think this needs a rebase |
sinhrks
force-pushed
the
depr_legacy_offset
branch
from
b554bc7
to
65205be
Compare
sinhrks
force-pushed
the
depr_legacy_offset
branch
from
65205be
to
2593b1f
Compare
jreback
pushed a commit
that referenced
this pull request
Aug 2, 2016
Follow-up to #13590. Remove legacy offset aliases that remained in `pandas/tseries/frequencies.py`: `_period_alias_dictionary()` and `_period_alias_dict`. Author: agraboso <agraboso@gmail.com> Closes #13868 from agraboso/follow-13590 and squashes the following commits: 25d932d [agraboso] DEPR: Remove legacy offsets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffFollow-up of #10951. Remove legacy offsets deprecated in 0.17.0.