DEPR: rename Timestamp.offset to .freq #13593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| # Temp, | ||
| # Categorical.categories is changed from str to bytes in PY3 | ||
| # maybe the same as GH 13591 | ||
| if PY3 and b.categories.inferred_type == 'string': |
There was a problem hiding this comment.
seems to be the same issue as #13591
Current coverage is 84.31%
|
sinhrks
force-pushed
the
depr_timestamp_offset
branch
from
ec2fe22
to
c7749d5
Compare
| else: | ||
| tm.assert_categorical_equal(a, b) | ||
| elif a is NaT: | ||
| assert b is NaT |
There was a problem hiding this comment.
we should prob change the comparators to be like the rest of pandas (e.g. assertTrue).... but can do later
sinhrks
force-pushed
the
depr_timestamp_offset
branch
from
c7749d5
to
5491fb6
Compare
|
thanks @sinhrks I had to do a couple of more renames to avoid the warnings...but no biggie. not that |
|
Thanks, let me do a follow-up for testing |
3 tasks
nateGeorge
pushed a commit
to nateGeorge/pandas
that referenced
this pull request
Aug 15, 2016
closes pandas-dev#12160 Author: sinhrks <sinhrks@gmail.com> Closes pandas-dev#13593 from sinhrks/depr_timestamp_offset and squashes the following commits: c7749d5 [sinhrks] DEPR: rename Timestamp.offset to .freq
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Dec 24, 2017
Deprecated in v0.19.0 xref pandas-devgh-13593
jreback
pushed a commit
that referenced
this pull request
Dec 26, 2017
Deprecated in v0.19.0 xref gh-13593
hexgnu
pushed a commit
to hexgnu/pandas
that referenced
this pull request
Dec 28, 2017
Deprecated in v0.19.0 xref pandas-devgh-13593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff