Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: remove radd workaround in ops.py #13606

Closed
wants to merge 1 commit into from

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Jul 10, 2016

  • tests added / passed
  • passes git diff upstream/master | flake8 --diff

Remove workaround added in #353. The test added at that time has been passed.

@sinhrks sinhrks added Numeric Operations Arithmetic, Comparison, and Logical operations Clean labels Jul 10, 2016
@sinhrks sinhrks added this to the 0.19.0 milestone Jul 10, 2016
@codecov-io
Copy link

codecov-io commented Jul 10, 2016

Current coverage is 84.31%

Merging #13606 into master will increase coverage by <.01%

@@             master     #13606   diff @@
==========================================
  Files           138        138          
  Lines         51157      51146    -11   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43131      43122     -9   
+ Misses         8026       8024     -2   
  Partials          0          0          

Powered by Codecov. Last updated by 5701c69...d873aad

@jreback
Copy link
Contributor

jreback commented Jul 10, 2016

lgtm
independent of #13605 ?

@sinhrks
Copy link
Member Author

sinhrks commented Jul 10, 2016

Yes independent, and whichever order is OK.

@jreback jreback closed this in 1edc1df Jul 10, 2016
@sinhrks sinhrks deleted the ops_radd_cln branch July 10, 2016 21:34
nateGeorge pushed a commit to nateGeorge/pandas that referenced this pull request Aug 15, 2016
Remove workaround added in pandas-dev#353.

Author: sinhrks <sinhrks@gmail.com>

Closes pandas-dev#13606 from sinhrks/ops_radd_cln and squashes the following commits:

d873aad [sinhrks] CLN: remove radd workaround
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants