Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNL: remove the io.data and io.wb modules #13735

Merged

Conversation

jorisvandenbossche
Copy link
Member

Closes #13724

return frame
raise ImportError(
"The pandas.io.data module is moved to a separate package "
"(pandas-datareader). After installing the pandas-datareader package "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need an issue to remove this in the future :>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, added an entry in the overview at #6581

@jreback
Copy link
Contributor

jreback commented Jul 24, 2016

@jorisvandenbossche ok lgtm (and fine to have error on both).

@jorisvandenbossche jorisvandenbossche merged commit 81a5c98 into pandas-dev:master Jul 24, 2016
@jorisvandenbossche jorisvandenbossche deleted the remove-datareader branch July 24, 2016 18:03
@jreback
Copy link
Contributor

jreback commented Jul 24, 2016

whoo hoo!

@gfyoung
Copy link
Member

gfyoung commented Jul 24, 2016

@jorisvandenbossche : any reason why we just didn't add pandas-datareader as a dependency and do a try-except block with import pandas-datareader? I ask because in the README for pandas-datareader, it seems to imply that pandas should be dependent on pandas-datareader by now.

@jreback
Copy link
Contributor

jreback commented Jul 24, 2016

the dependency is the other way
u can submit a PR to pandas-datareader if you want to change the wording

@gfyoung
Copy link
Member

gfyoung commented Jul 24, 2016

@jreback : fair enough, but I still don't get why we didn't do try-except with pandas-datareader, or rather, why we even have these files (wb.py and data.py) at all in the pandas library still.

@jreback
Copy link
Contributor

jreback commented Jul 24, 2016

they raise a more helpful message

@gfyoung
Copy link
Member

gfyoung commented Jul 24, 2016

@jreback : Ah, so we're helping people with transitioning from io.data to pandas-datareader?

@jreback
Copy link
Contributor

jreback commented Jul 24, 2016

of course -

@jorisvandenbossche
Copy link
Member Author

Hmm, didn't see that in the readme of pandas-datareader (and it's not how it is phrased in the pandas docs). Anyway, I see that your PR over there has already been merged.
As I said in the issue #13724, there was some unresolved discussion about this at the time we deprecated it and created pandas-datareader (I think @hayd was in favor of doing it like you say).

Keeping the file with the custom import error is indeed to have a more helpful error for transitioning to pandas-datareader.

gfyoung added a commit to forking-repos/pandas that referenced this pull request Dec 3, 2017
gfyoung added a commit to forking-repos/pandas that referenced this pull request Dec 4, 2017
jreback pushed a commit that referenced this pull request Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants