-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNL: remove the io.data and io.wb modules #13735
CNL: remove the io.data and io.wb modules #13735
Conversation
return frame | ||
raise ImportError( | ||
"The pandas.io.data module is moved to a separate package " | ||
"(pandas-datareader). After installing the pandas-datareader package " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need an issue to remove this in the future :>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, added an entry in the overview at #6581
@jorisvandenbossche ok lgtm (and fine to have error on both). |
whoo hoo! |
@jorisvandenbossche : any reason why we just didn't add |
the dependency is the other way |
@jreback : fair enough, but I still don't get why we didn't do |
they raise a more helpful message |
@jreback : Ah, so we're helping people with transitioning from |
of course - |
Hmm, didn't see that in the readme of pandas-datareader (and it's not how it is phrased in the pandas docs). Anyway, I see that your PR over there has already been merged. Keeping the file with the custom import error is indeed to have a more helpful error for transitioning to pandas-datareader. |
Deprecated in 0.17.0. xref pandas-devgh-13735.
Deprecated in 0.17.0. xref pandas-devgh-13735.
Deprecated in 0.17.0. xref gh-13735.
Closes #13724