CLN: Removed SparsePanel #13778
CLN: Removed SparsePanel #13778
Conversation
| @@ -330,6 +330,7 @@ API changes | |||
| ~~~~~~~~~~~ | |||
|
|
|||
|
|
|||
| - ``Panel.to_sparse`` will raise a ``NotImplementedError`` exception when called (:issue:``) | |||
There was a problem hiding this comment.
Note to self: add PR number once Travis passes
|
this is in slight conflict with #13776 as I needed to add a line to catch an errant warning about SparsePanel (which you should then remove). But can sort that later I guess. |
|
|
||
| y = sdf | ||
| x = SparsePanel({'x1': sdf + new_data_like(sdf) / 10, | ||
| 'x2': sdf + new_data_like(sdf) / 10}) |
There was a problem hiding this comment.
The benchmark centres around this SparsePanel, which if removed, renders this benchmark essentially moot.
There was a problem hiding this comment.
that's fine (we are going to remove those benchs shortly anyway, after checking the content, there is an issue for it. And this one doesn't contain any content that should be moved, so fine!)
| ``SparseArray`` can be converted back to a regular ndarray by calling | ||
| ``to_dense``: | ||
| Like the indexed objects (SparseSeries, SparseDataFrame), a ``SparseArray`` | ||
| can be converted back to a regular ndarray by calling ``to_dense``: |
There was a problem hiding this comment.
maybe add a warning note somewhere that SparsePanel was deprecated in 0.19.0
There was a problem hiding this comment.
You mean "removed in 0.19.0" ?
|
@jreback : what error catching are you referring to in your PR? |
gfyoung
force-pushed
the
remove-sparse-panel
branch
from
8cb813a
to
7011f39
Compare
Current coverage is 85.23% (diff: 75.00%)@@ master #13778 diff @@
==========================================
Files 141 140 -1
Lines 50711 50415 -296
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43275 42969 -306
- Misses 7436 7446 +10
Partials 0 0
|
| example. All of the standard pandas data structures have a ``to_sparse`` | ||
| method: | ||
| We have implemented "sparse" versions of Series and DataFrame (there used to be | ||
| one for Panel but was removed in 0.19.0). These are not sparse in the typical |
There was a problem hiding this comment.
put it in a separate note about the removal of the SparsePanel.
There was a problem hiding this comment.
I have a parenthetical above your comment about the removal. How about a separate paragraph underneath this one instead?
There was a problem hiding this comment.
put it in a warning or note, just trying to draw attention. It should be the first item in that section.
|
lgtm @gfyoung minor doc changes. ping when green. |
|
@gfyoung I think I took out the reference in my other PR (to SparsePanel); I'll rebase after this. |
gfyoung
force-pushed
the
remove-sparse-panel
branch
from
7011f39
to
92b21d5
Compare
gfyoung
force-pushed
the
remove-sparse-panel
branch
from
92b21d5
to
f3fa93b
Compare
|
thanks @gfyoung |
Title is self-explanatory. Picks up where #11157 left off.