Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch warning introduced by GH14432 in test case #14902

Closed
wants to merge 1 commit into from

Conversation

jonmmease
Copy link
Contributor

Follow on to #14432 to catch the newly introduced FutureWarning in the test_groupby_multi_categorical_as_index test case.

@jreback
Copy link
Contributor

jreback commented Dec 17, 2016

thanks!

of course I just merged a pr where we moved the tests :)

can you move

@jreback jreback added Groupby Testing pandas testing functions or related to the test suite labels Dec 17, 2016
@jonmmease
Copy link
Contributor Author

Haha, yeah, I was a bit confused for a minute there. Changes should be moved to new location now.

@jreback jreback added this to the 0.20.0 milestone Dec 17, 2016
@codecov-io
Copy link

codecov-io commented Dec 17, 2016

Current coverage is 84.55% (diff: 100%)

Merging #14902 into master will decrease coverage by <.01%

@@             master     #14902   diff @@
==========================================
  Files           144        144          
  Lines         51043      51043          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43160      43159     -1   
- Misses         7883       7884     +1   
  Partials          0          0          

Powered by Codecov. Last update 73bc6cf...c30fa2b

@jreback jreback closed this in f5c8d54 Dec 17, 2016
@jreback
Copy link
Contributor

jreback commented Dec 17, 2016

thanks!

ischurov pushed a commit to ischurov/pandas that referenced this pull request Dec 19, 2016
Follow on to pandas-dev#14432 to catch the newly introduced `FutureWarning` in
the `test_groupby_multi_categorical_as_index` test case.

Author: Jon M. Mease <jon.mease@jhuapl.edu>

Closes pandas-dev#14902 from jmmease/GH14432_follow_on and squashes the following commits:

c30fa2b [Jon M. Mease] Trap warning introduced by GH14432 in test_groupby_multi_categorical_as_index
ShaharBental pushed a commit to ShaharBental/pandas that referenced this pull request Dec 26, 2016
Follow on to pandas-dev#14432 to catch the newly introduced `FutureWarning` in
the `test_groupby_multi_categorical_as_index` test case.

Author: Jon M. Mease <jon.mease@jhuapl.edu>

Closes pandas-dev#14902 from jmmease/GH14432_follow_on and squashes the following commits:

c30fa2b [Jon M. Mease] Trap warning introduced by GH14432 in test_groupby_multi_categorical_as_index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants