BUG: Convert uint64 in maybe_convert_objects #14916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
convert-objects-uint64
branch
from
5aee259
to
92f10f3
Compare
Current coverage is 84.64% (diff: 100%)@@ master #14916 diff @@
==========================================
Files 144 144
Lines 51016 51016
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43184 43185 +1
+ Misses 7832 7831 -1
Partials 0 0
|
jreback
reviewed
Dec 19, 2016
| try: | ||
| ints[i] = val | ||
| except OverflowError: | ||
| seen_uint = seen_uint or (val > np.iinfo(np.int64).max) |
There was a problem hiding this comment.
I would pull set np.iinfo(np.int64).max as a constant in the module.
jreback
reviewed
Dec 19, 2016
| @@ -234,6 +234,21 @@ def test_empty_like(self): | |||
| self._check_behavior(arr, expected) | |||
|
|
|||
|
|
|||
| def test_maybe_convert_objects_uint64(): | |||
There was a problem hiding this comment.
these tests are all in
pandas.types.test_inference
jreback
reviewed
Dec 19, 2016
| @@ -251,3 +251,4 @@ Bug Fixes | |||
|
|
|||
|
|
|||
| - Require at least 0.23 version of cython to avoid problems with character encodings (:issue:`14699`) | |||
| - Bug in ``lib.maybe_convert_objects()`` in which unsigned 64-bit integers were not being properly converted (:issue:`4471`) | |||
There was a problem hiding this comment.
this is not public. I would refer to this more generically (maybe also construct a test which actually hits this in practice from a user perspective)
gfyoung
force-pushed
the
convert-objects-uint64
branch
3 times, most recently
from
edb04d3
to
47de0df
Compare
Adds handling for uint64 objects during conversion. When negative numbers and uint64 are detected, we then convert the result to object. Picks up where pandas-devgh-4845 left off. Closes pandas-devgh-4471.
gfyoung
force-pushed
the
convert-objects-uint64
branch
from
47de0df
to
ed325cd
Compare
|
thanks! |
This was referenced Dec 21, 2016
ShaharBental
pushed a commit
to ShaharBental/pandas
that referenced
this pull request
Dec 26, 2016
Adds handling for `uint64` objects during conversion. When negative numbers and `uint64` are detected, we then convert the result to `object`. Picks up where pandas-dev#4845 left off. Closes pandas-dev#4471. Author: gfyoung <gfyoung17@gmail.com> Closes pandas-dev#14916 from gfyoung/convert-objects-uint64 and squashes the following commits: ed325cd [gfyoung] BUG: Convert uint64 in maybe_convert_objects
jreback
pushed a commit
that referenced
this pull request
Jan 17, 2017
1) Introduces and propagates `UInt64Index`, an index specifically for `uint`. xref #14935 2) <strike> Patches bug from #14916 that makes `maybe_convert_objects` robust against the known `numpy` bug that `uint64` cannot be compared to `int64`. This bug was caught during testing of `UInt64Index`. </strike> **UPDATE**: Patched in #14951 Author: gfyoung <gfyoung17@gmail.com> Closes #14937 from gfyoung/create-uint64-index and squashes the following commits: 8ab6fbd [gfyoung] ENH: Create and propagate UInt64Index
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
1) Introduces and propagates `UInt64Index`, an index specifically for `uint`. xref pandas-dev#14935 2) <strike> Patches bug from pandas-dev#14916 that makes `maybe_convert_objects` robust against the known `numpy` bug that `uint64` cannot be compared to `int64`. This bug was caught during testing of `UInt64Index`. </strike> **UPDATE**: Patched in pandas-dev#14951 Author: gfyoung <gfyoung17@gmail.com> Closes pandas-dev#14937 from gfyoung/create-uint64-index and squashes the following commits: 8ab6fbd [gfyoung] ENH: Create and propagate UInt64Index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds handling for
uint64objects during conversion. When negative numbers anduint64are detected, we then convert the result toobject.Picks up where #4845 left off. Closes #4471.