BUG: Don't convert uint64 to object in DataFrame init #14917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hack used to resolve pandas-devgh-2355 is no longer needed. Removes the hack and patches several tests that relied on this hacky (and buggy) behavior. Closes pandas-devgh-14881.
gfyoung
changed the title
gfyoung
force-pushed
the
df-init-uint64
branch
from
de6a43b to
9fe2199
Compare
Current coverage is 84.57% (diff: 100%)@@ master #14917 diff @@
==========================================
Files 144 144
Lines 51057 51053 -4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43180 43177 -3
+ Misses 7877 7876 -1
Partials 0 0
|
|
can you add the actual given test from the issue as well. |
|
@jreback : It's no different from the first test of |
|
ok then. |
ShaharBental
pushed a commit
to ShaharBental/pandas
that referenced
this pull request
Dec 26, 2016
The hack used to resolve pandas-devgh-2355 is no longer needed. Removes the hack and patches several tests that relied on this hacky (and buggy) behavior. Closes pandas-devgh-14881.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hack used to resolve #2355 is no longer needed. Removes the hack and patches several tests that relied on this hacky (and buggy) behavior.
Closes #14881.