-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN/DEPR: remove deprecated pandas.rpy module (GH9602) #15142
CLN/DEPR: remove deprecated pandas.rpy module (GH9602) #15142
Conversation
@@ -60,7 +60,7 @@ can be replaced with:: | |||
|
|||
from rpy2.robjects import r | |||
r.data('iris') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove everything here except for the top warning, then put a link to the previous page of the built docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, the docs were still 'to do'. What I was thinking to do is update the current examples to just use the corresponding rpy2
functions. So then there is still some documentation on how to use it (for the updating, I can refer to docs of previous version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure if that works, just make a note (e.g. import at the top and indicate), you are importing an external library to do this.
just a doc comment, otherwise lgtm. |
good to go? |
it's nice to update ecosystem doc to describe rpy2 and PypeR. |
@sinhrks do you know how maintained PypeR is, and whether pandas is supported well or not? |
@jorisvandenbossche their website is below, but can't find actual repo (looks to be not maintainanced 2014)? http://www.webarray.org/softwares/PypeR/ The package has
Pls drop |
fc65c52
to
e9d2d10
Compare
Current coverage is 85.97% (diff: 100%)@@ master #15142 diff @@
==========================================
Files 145 140 -5
Lines 51430 51244 -186
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 44070 44057 -13
+ Misses 7360 7187 -173
Partials 0 0
|
http://pandas-docs.github.io/pandas-docs-travis/r_interface.html#rpy something not defined here? |
Hmm, sigh. This worked locally, but I now see this only worked because I didn't activate pandas2ri. But if I don't activate pandas2ri, the second example does not work. I can't really get my head around rpy2's conversion/activate/dispatch rules and object model .. |
Closes #9602