Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN/DEPR: remove deprecated pandas.rpy module (GH9602) #15142

Merged
merged 1 commit into from
Jan 22, 2017

Conversation

jorisvandenbossche
Copy link
Member

Closes #9602

@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Jan 16, 2017
@jorisvandenbossche jorisvandenbossche added the Deprecate Functionality to remove in pandas label Jan 16, 2017
@@ -60,7 +60,7 @@ can be replaced with::

from rpy2.robjects import r
r.data('iris')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove everything here except for the top warning, then put a link to the previous page of the built docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the docs were still 'to do'. What I was thinking to do is update the current examples to just use the corresponding rpy2 functions. So then there is still some documentation on how to use it (for the updating, I can refer to docs of previous version).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure if that works, just make a note (e.g. import at the top and indicate), you are importing an external library to do this.

@jreback
Copy link
Contributor

jreback commented Jan 17, 2017

just a doc comment, otherwise lgtm.

@jreback
Copy link
Contributor

jreback commented Jan 18, 2017

good to go?

@sinhrks
Copy link
Member

sinhrks commented Jan 19, 2017

it's nice to update ecosystem doc to describe rpy2 and PypeR.

@jorisvandenbossche
Copy link
Member Author

@sinhrks do you know how maintained PypeR is, and whether pandas is supported well or not?

@sinhrks
Copy link
Member

sinhrks commented Jan 21, 2017

@jorisvandenbossche their website is below, but can't find actual repo (looks to be not maintainanced 2014)?

http://www.webarray.org/softwares/PypeR/

The package has use_pandas to handle DataFrame and Series. From their source impl, rpy2 is expected to work better.

        use_pandas: Used as a boolean value. A False value will disable pandas
            even if it has been imported. 

Pls drop PypeR description if it is not appropriate.

@codecov-io
Copy link

codecov-io commented Jan 22, 2017

Current coverage is 85.97% (diff: 100%)

Merging #15142 into master will increase coverage by 0.28%

@@             master     #15142   diff @@
==========================================
  Files           145        140     -5   
  Lines         51430      51244   -186   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          44070      44057    -13   
+ Misses         7360       7187   -173   
  Partials          0          0          

Powered by Codecov. Last update 2fa33fb...e9d2d10

@jorisvandenbossche jorisvandenbossche merged commit 1f82e39 into pandas-dev:master Jan 22, 2017
@jreback
Copy link
Contributor

jreback commented Jan 22, 2017

@jorisvandenbossche
Copy link
Member Author

Hmm, sigh. This worked locally, but I now see this only worked because I didn't activate pandas2ri. But if I don't activate pandas2ri, the second example does not work. I can't really get my head around rpy2's conversion/activate/dispatch rules and object model ..
(will do a PR to fix this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants