Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Drop the name parameter from Categorical #15654

Closed

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Mar 11, 2017

Deprecated in 0.17.0

xref #10632

@@ -690,6 +690,7 @@ Other API Changes
- ``pandas.api.types.is_datetime64_ns_dtype`` will now report ``True`` on a tz-aware dtype, similar to ``pandas.api.types.is_datetime64_any_dtype``
- ``DataFrame.asof()`` will return a null filled ``Series`` instead the scalar ``NaN`` if a match is not found (:issue:`15118`)
- Reorganization of timeseries development tests (:issue:`14854`)
- The ``Categorical`` constructor has dropped the ``name`` parameter (:issue:`10632`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a specific section for removals below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@codecov-io
Copy link

codecov-io commented Mar 11, 2017

Codecov Report

Merging #15654 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15654      +/-   ##
==========================================
- Coverage   91.03%   91.01%   -0.03%     
==========================================
  Files         143      143              
  Lines       49390    49384       -6     
==========================================
- Hits        44964    44947      -17     
- Misses       4426     4437      +11
Impacted Files Coverage Δ
pandas/io/packers.py 87.57% <ø> (ø)
pandas/core/categorical.py 96.89% <100%> (-0.03%)
pandas/io/gbq.py 25% <0%> (-58.34%)
pandas/tools/merge.py 93.61% <0%> (-0.34%)
pandas/core/frame.py 97.87% <0%> (-0.1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 026e748...7e1e7d8. Read the comment docs.

@jreback jreback added Categorical Categorical Data Type Deprecate Functionality to remove in pandas labels Mar 11, 2017
@jreback jreback added this to the 0.20.0 milestone Mar 11, 2017
@jreback
Copy link
Contributor

jreback commented Mar 11, 2017

thanks!

@jreback jreback closed this in aa53e4f Mar 11, 2017
@gfyoung gfyoung deleted the categorical-name-drop branch March 11, 2017 18:57
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
Deprecated in 0.17.0

xref pandas-dev#10632

Author: gfyoung <gfyoung17@gmail.com>

Closes pandas-dev#15654 from gfyoung/categorical-name-drop and squashes the following commits:

7e1e7d8 [gfyoung] API: Drop the name parameter from Categorical
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants