MAINT: Enforce string type for where parameter #15798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15798 +/- ##
==========================================
- Coverage 91.01% 91% -0.01%
==========================================
Files 143 143
Lines 49400 49370 -30
==========================================
- Hits 44963 44931 -32
- Misses 4437 4439 +2
Continue to review full report at Codecov.
|
|
lgtm. can you add a deprecation removal note. ping when pushed. |
|
also this might still be used in the doc-build (though I think I took most of this out). can you check? |
jreback
added
Deprecate
|
@jreback : I don't see any AFAICT. |
jreback
approved these changes
Mar 25, 2017
| if not (isinstance(w, (Expr, string_types)) or is_list_like(w)): | ||
| raise TypeError("where must be passed as a string, Expr, " | ||
| "or list-like of Exprs") | ||
|
|
There was a problem hiding this comment.
you could return w here
makes it a bit more natural to use it
pandas/computation/pytables.py
Outdated
|
|
||
| # try to be back compat | ||
| where = self.parse_back_compat(where, op, value) | ||
| _validate_where(where) | ||
|
|
There was a problem hiding this comment.
where = _validate_where(where)
Deprecated in 0.11.0. xref pandas-devgh-12027.
gfyoung
force-pushed
the
where-string-enforce
branch
from
eb6071f
to
06adda1
Compare
|
thanks @gfyoung |
mattip
pushed a commit
to mattip/pandas
that referenced
this pull request
Apr 3, 2017
Deprecated in 0.11.0. xref pandas-dev#12027. Author: gfyoung <gfyoung17@gmail.com> Closes pandas-dev#15798 from gfyoung/where-string-enforce and squashes the following commits: 06adda1 [gfyoung] MAINT: Enforce string type for where parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated in 0.11.0.
xref #12027.