MAINT: Remove self.assertTrue from testing

[gfyoung]

Title is self-explanatory.

Partially addresses #15990.

[gfyoung]

Appveyor failing due to network issues. Travis and Circle seem okay.

@jreback : Could you restart the Appveyor build?

[jreback]

yeah those are 'network' tests that don't have the decorator! (as I think there is some interaction with parametrize).

[codecov]

Codecov Report

Merging #16158 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #16158      +/-   ##
==========================================
+ Coverage   90.85%   90.85%   +<.01%     
==========================================
  Files         159      159              
  Lines       50785    50785              
==========================================
+ Hits        46141    46143       +2     
+ Misses       4644     4642       -2

Flag	Coverage Δ
#multiple	88.64% <ø> (ø)	⬆️
#single	40.32% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/core/indexes/datetimes.py	95.43% <0%> (+0.09%)	⬆️
pandas/core/common.py	91.03% <0%> (+0.34%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9909c...ee96e02. Read the comment docs.

[codecov]

Codecov Report

Merging #16158 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #16158      +/-   ##
==========================================
+ Coverage   90.85%   90.85%   +<.01%     
==========================================
  Files         159      159              
  Lines       50785    50785              
==========================================
+ Hits        46141    46143       +2     
+ Misses       4644     4642       -2

Flag	Coverage Δ
#multiple	88.64% <ø> (ø)	⬆️
#single	40.32% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/core/indexes/datetimes.py	95.43% <0%> (+0.09%)	⬆️
pandas/core/common.py	91.03% <0%> (+0.34%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9909c...ee96e02. Read the comment docs.

[jreback]

thanks!

[gfyoung]

yeah those are 'network' tests that don't have the decorator!

Is there a reason the tm.network decorator is not applied?

[jreback]

Is there a reason the tm.network decorator is not applied?

I think I briefly tried it and couldn't get it to work when the parameterize one was as well.
give it a shot!

[gfyoung]

The test is actually decorated because the function called in each test has the tm.network decorator. I suspect it's because network failures are supposed to trigger test failures per the documentation of tm.network.