Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: deprecate is_any_int_dtype and is_floating_dtype from pandas.api.types #16163

Merged
merged 3 commits into from
Apr 28, 2017
Merged

DEPR: deprecate is_any_int_dtype and is_floating_dtype from pandas.api.types #16163

merged 3 commits into from
Apr 28, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Apr 27, 2017

closes #16042

@jreback jreback added Deprecate Functionality to remove in pandas Docs labels Apr 27, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 27, 2017
@jsexauer jsexauer mentioned this pull request Apr 27, 2017
Closed
1 task
@codecov
Copy link

codecov bot commented Apr 27, 2017 •
edited
Loading

Codecov Report

Merging #16163 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16163      +/-   ##
==========================================
+ Coverage   90.87%   90.87%   +<.01%     
==========================================
  Files         162      162              
  Lines       50816    50826      +10     
==========================================
+ Hits        46178    46190      +12     
+ Misses       4638     4636       -2
Flag Coverage Δ
#multiple 88.66% <100%> (ø) ⬆️
#single 40.33% <66.66%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/api/types/__init__.py 100% <ø> (ø) ⬆️
pandas/core/dtypes/api.py 100% <100%> (ø) ⬆️
pandas/core/dtypes/common.py 93.5% <0%> (+0.25%) ⬆️
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075eca1...1651d74. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 27, 2017 •
edited
Loading

Codecov Report

Merging #16163 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16163      +/-   ##
==========================================
- Coverage   90.87%   90.85%   -0.02%     
==========================================
  Files         162      162              
  Lines       50816    50826      +10     
==========================================
  Hits        46178    46178              
- Misses       4638     4648      +10
Flag Coverage Δ
#multiple 88.63% <100%> (-0.02%) ⬇️
#single 40.33% <66.66%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/api/types/__init__.py 100% <ø> (ø) ⬆️
pandas/core/dtypes/api.py 100% <100%> (ø) ⬆️
pandas/plotting/_converter.py 63.54% <0%> (-1.82%) ⬇️
pandas/core/dtypes/common.py 93.5% <0%> (+0.25%) ⬆️
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075eca1...6d97cfa. Read the comment docs.

jorisvandenbossche
jorisvandenbossche approved these changes Apr 28, 2017
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only added the is_*_dtype ones to the docs, is there a reason for that?

@jreback
Copy link
Contributor Author

jreback commented Apr 28, 2017

added the rest.

@jreback jreback merged commit b6f65eb into pandas-dev:master Apr 28, 2017
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
@jreback @pcluo
DEPR: deprecate is_any_int_dtype and is_floating_dtype from pandas.ap…
2d73198 
…i.types (pandas-dev#16163)

* DEPR: deprecate is_any_int_dtype and is_floating_dtype from pandas.api.types

closes pandas-dev#16042

* is_ docs
gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 27, 2018
@gfyoung
CLN: Remove some dtype methods from API
8110871 
Removes the following from the public API:

* pandas.api.types.is_sequence
* pandas.api.types.is_any_int_dtype
* pandas.api.types.is_floating_dtype

xref pandas-devgh-16163.
xref pandas-devgh-16189.
@gfyoung gfyoung mentioned this pull request Oct 27, 2018
Merged
@jreback jreback mentioned this pull request Oct 27, 2018
Closed
gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 28, 2018
@gfyoung
CLN: Remove some dtype methods from API
49b8c74 
Removes the following from the public API:

* pandas.api.types.is_sequence
* pandas.api.types.is_any_int_dtype
* pandas.api.types.is_floating_dtype

xref pandas-devgh-16163.
xref pandas-devgh-16189.
jreback pushed a commit that referenced this pull request Oct 28, 2018
@gfyoung @jreback
CLN: Remove some dtype methods from API (#23390)
f646fcf 
Removes the following from the public API:

* pandas.api.types.is_sequence
* pandas.api.types.is_any_int_dtype
* pandas.api.types.is_floating_dtype

xref gh-16163.
xref gh-16189.
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@gfyoung @tm9k1
CLN: Remove some dtype methods from API (pandas-dev#23390)
4097f91 
Removes the following from the public API:

* pandas.api.types.is_sequence
* pandas.api.types.is_any_int_dtype
* pandas.api.types.is_floating_dtype

xref pandas-devgh-16163.
xref pandas-devgh-16189.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
CLN: Remove some dtype methods from API (pandas-dev#23390)
e1b3f54 
Removes the following from the public API:

* pandas.api.types.is_sequence
* pandas.api.types.is_any_int_dtype
* pandas.api.types.is_floating_dtype

xref pandas-devgh-16163.
xref pandas-devgh-16189.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
CLN: Remove some dtype methods from API (pandas-dev#23390)
a6c1864 
Removes the following from the public API:

* pandas.api.types.is_sequence
* pandas.api.types.is_any_int_dtype
* pandas.api.types.is_floating_dtype

xref pandas-devgh-16163.
xref pandas-devgh-16189.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Docs
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

API: scope of the public types module
2 participants
@jreback @jorisvandenbossche