-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return empty MultiIndex for symmetrical difference on equal MultiIndexes #16486
Merged
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4903b20
return empty MultiIndex for symmetrical difference on equal MultiIndexes
Tafkas 743aa47
move test to its own method test_symmetric_difference_on_equal_multii…
Tafkas 0200ca0
Merge remote-tracking branch 'upstream/master'
Tafkas efb5f86
update whatsnew
Tafkas 7eeb626
Merge remote-tracking branch 'upstream/master'
Tafkas 0dee788
Merge remote-tracking branch 'upstream/master'
Tafkas 104d8e6
move empty MultiIndex creation to MultiIndex._shallow_copy
Tafkas f49bcfc
Merge remote-tracking branch 'upstream/master'
Tafkas 85b4b55
remove old test
Tafkas f2d24a3
move block to _shallow_copy_with_infer
Tafkas 4cd39a9
PEP8 compliancy
Tafkas 6c67a4a
Merge remote-tracking branch 'upstream/master'
Tafkas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -419,6 +419,11 @@ def _shallow_copy_with_infer(self, values=None, **kwargs): | |
@Appender(_index_shared_docs['_shallow_copy']) | ||
def _shallow_copy(self, values=None, **kwargs): | ||
if values is not None: | ||
# On equal MultiIndexes the difference is empty. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this block can simply go in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changed it |
||
# Therefore, an empty MultiIndex is returned GH13490 | ||
if len(values) == 0: | ||
return MultiIndex(levels=[[] for _ in range(self.nlevels)], | ||
labels=[[] for _ in range(self.nlevels)], **kwargs) | ||
if 'name' in kwargs: | ||
kwargs['names'] = kwargs.pop('name', None) | ||
# discards freq | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Index.symmetric_difference()
on two equal MultiIndex's, results in aTypeError