TST: ujson tests are not being run (#16499) #16500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add Test prefix on classes to enable PyTest picking them up. add underscore in test method where applicable. E.G. testBool() to test_Bool().
jreback
added
IO JSON
|
lgtm. ping on green. |
Codecov Report
@@ Coverage Diff @@
## master #16500 +/- ##
==========================================
+ Coverage 90.43% 90.43% +<.01%
==========================================
Files 161 161
Lines 51045 51045
==========================================
+ Hits 46161 46162 +1
+ Misses 4884 4883 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16500 +/- ##
==========================================
+ Coverage 90.43% 90.79% +0.36%
==========================================
Files 161 161
Lines 51045 51063 +18
==========================================
+ Hits 46161 46365 +204
+ Misses 4884 4698 -186
Continue to review full report at Codecov.
|
|
looks like a linting error (the 2.7 build), ignore the fail on 3.6. ping on green. |
|
thanks! |
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
May 29, 2017
closes pandas-dev#16499 (cherry picked from commit 6649157)
TomAugspurger
pushed a commit
that referenced
this pull request
May 30, 2017
Kiv
pushed a commit
to Kiv/pandas
that referenced
this pull request
Jun 11, 2017
stangirala
pushed a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Test prefix on classes to enable PyTest picking them up.
add underscore in test method where applicable. E.G. testBool() to test_Bool().
git diff upstream/master --name-only -- '*.py' | flake8 --diff