TST: Avoid global state in matplotlib tests #16539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces most uses of implicit global state from matplotlib in test_datetimelike.py. This was potentially causing random failures where a figure expected to be on a new, blank figure would instead plot on an existing axes (that's the guess at least).
TomAugspurger
added
Testing
Codecov Report
@@ Coverage Diff @@
## master #16539 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 161 161
Lines 51063 51063
=======================================
Hits 46365 46365
Misses 4698 4698
Continue to review full report at Codecov.
|
|
I'm going to rerun the occasionally failing worker 4-5 times to see if I can get a failure. 5 / 5 so far. |
|
looks much cleaner to me! |
Kiv
pushed a commit
to Kiv/pandas
that referenced
this pull request
Jun 11, 2017
Replaces most uses of implicit global state from matplotlib in test_datetimelike.py. This was potentially causing random failures where a figure expected to be on a new, blank figure would instead plot on an existing axes (that's the guess at least).
stangirala
pushed a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
Replaces most uses of implicit global state from matplotlib in test_datetimelike.py. This was potentially causing random failures where a figure expected to be on a new, blank figure would instead plot on an existing axes (that's the guess at least).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces most uses of implicit global state from matplotlib in
test_datetimelike.py and test_series.py. This was potentially causing random failures
where a figure expected to be on a new, blank figure would instead
plot on an existing axes (that's the guess at least).
Closes #16371 (hopefully).