ENH: add more possible bool values to read_csv #1295 #1691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a unit test? |
| @@ -654,9 +654,11 @@ def maybe_convert_bool(ndarray[object] arr): | |||
| for i from 0 <= i < n: | |||
| val = arr[i] | |||
|
|
|||
| if val == 'True' or type(val) == bool and val: | |||
| true_vals = ('True', 'TRUE', 'true', 'Yes', 'YES', 'yes') | |||
| false_vals = ('False', 'FALSE', 'false', 'No', 'NO', 'no') | |||
There was a problem hiding this comment.
for future Python endeavors, I wouldn't recommend putting constant variables like these inside the for loop (very inefficient)
wesm
added a commit
that referenced
this pull request
Sep 12, 2012
|
I merged this in. Hopeful it won't cause big problems |
|
Woops, sorry, didn't realize I was doing that, will be more careful next On Wed, Sep 12, 2012 at 11:04 AM, Wes McKinney notifications@git.luolix.topwrote:
|
yarikoptic
added a commit
to neurodebian/pandas
that referenced
this pull request
Sep 27, 2012
* commit 'v0.8.1-203-g67121af': (193 commits) BUG: DataFrame column formatting issue in length-truncated column close pandas-dev#1906 BUG: override min/max in DatetimeIndex to function as expected close pandas-dev#1895 BUG: DataFrame mixed-type arithmetic column-wise, fix DataFrame.diff upcasting->object bug close pandas-dev#1896 BUG: treat nobs=1 >= min_periods case in rolling_std/variance as 0 trivially. close pandas-dev#1884 TST: skip to_file test if URLError occurs on some systems VB: resolve test name conflict and update make script DOC: minor change to build script to help auto build process DOC: fixed extlinks in sphinx conf TST: oops import in wrong place TST: skip test_console_encode if sys.stdin.encoding is None TST: unit test for pandas-dev#1902 and default to csv.QUOTE_MINIMAL Make it possible to set quoting for to_csv ENH: clean up pandas-dev#1691 changes, rls note ENH: add more possible bool values to read_csv pandas-dev#1295 BUG: fix rolling_max/min for small inputs and large windows. Add a check that the min_period <= window size. Fixes pandas-dev#1897. Mention Ubuntu for NeuroDebian repository BUG: don't clobber color keyword in Series.plot, close pandas-dev#1890 DOC: add intersphinx mapping for python library, close pandas-dev#1556 BUG: fix mixed-integer .ix indexing bugs. close#1799 BUG: unicode sheet name in to_excel pandas-dev#1828 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more possible bool values when parsing a file. New values include upper and lower case True/False and Yes/No.