Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: boolean masking with Index objects #17219

Closed
wants to merge 1 commit into from
Closed

BUG: boolean masking with Index objects #17219

wants to merge 1 commit into from

Conversation

naor2013
Copy link

@naor2013 naor2013 commented Aug 10, 2017 •
edited by jreback
Loading

closes #17131

@gfyoung gfyoung added Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version labels Aug 10, 2017
@codecov
Copy link

codecov bot commented Aug 10, 2017 •
edited
Loading

Codecov Report

Merging #17219 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17219      +/-   ##
==========================================
- Coverage   91.02%   91.01%   -0.02%     
==========================================
  Files         162      162              
  Lines       49517    49518       +1     
==========================================
- Hits        45075    45067       -8     
- Misses       4442     4451       +9
Flag Coverage Δ
#multiple 88.79% <100%> (ø) ⬆️
#single 40.27% <100%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/common.py 91.47% <100%> (+0.02%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.71% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f165b90...54af0dc. Read the comment docs.

@jreback jreback changed the title Fixes #17131 BUG: boolean masking with Index objects Aug 11, 2017
jreback
jreback requested changes Aug 11, 2017
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • needs a whatsnew note (indexing bugs)
  • needs a test (from the issue)

jreback
jreback reviewed Aug 11, 2017
View reviewed changes
pandas/core/common.py
@@ -182,7 +182,8 @@ def _maybe_box_datetimelike(value):


def is_bool_indexer(key):
if isinstance(key, (ABCSeries, np.ndarray)):
from pandas.core.index import Index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use ABCIndexClass here instead (and import were ABCSeries is imported)

@jreback
Copy link
Contributor

jreback commented Sep 23, 2017

can you rebase / update & add tests

@jreback
Copy link
Contributor

jreback commented Oct 2, 2017

superseded by #17738

@jreback jreback closed this Oct 2, 2017
@jorisvandenbossche jorisvandenbossche added this to the No action milestone Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor Bug: Boolean masking not working for Index objects
4 participants
@naor2013 @jreback @jorisvandenbossche @gfyoung