Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: deprecate .as_blocks() #17656

Merged
merged 1 commit into from
Sep 25, 2017
Merged

DEPR: deprecate .as_blocks() #17656

merged 1 commit into from
Sep 25, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Sep 24, 2017

closes #17302

@jreback jreback added the Deprecate Functionality to remove in pandas label Sep 24, 2017
@jreback jreback added this to the 0.21.0 milestone Sep 24, 2017
@codecov
Copy link

codecov bot commented Sep 24, 2017

Codecov Report

Merging #17656 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17656      +/-   ##
==========================================
- Coverage   91.26%   91.24%   -0.02%     
==========================================
  Files         163      163              
  Lines       49806    49805       -1     
==========================================
- Hits        45455    45446       -9     
- Misses       4351     4359       +8
Flag Coverage Δ
#multiple 89.04% <66.66%> (ø) ⬆️
#single 40.31% <33.33%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 92.09% <66.66%> (+0.04%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.73% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965c1c8...16706f7. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 24, 2017 •
edited
Loading

Codecov Report

Merging #17656 into master will decrease coverage by 0.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17656      +/-   ##
==========================================
- Coverage   91.26%   91.24%   -0.02%     
==========================================
  Files         163      163              
  Lines       49806    49805       -1     
==========================================
- Hits        45455    45446       -9     
- Misses       4351     4359       +8
Flag Coverage Δ
#multiple 89.04% <93.33%> (ø) ⬆️
#single 40.3% <66.66%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/computation/expressions.py 0% <ø> (ø) ⬆️
pandas/util/testing.py 100% <ø> (ø) ⬆️
pandas/core/window.py 96.37% <100%> (ø) ⬆️
pandas/core/internals.py 94.3% <100%> (+0.01%) ⬆️
pandas/core/generic.py 92.07% <87.5%> (+0.02%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.73% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da85b3...aa2d9d6. Read the comment docs.

@jsexauer jsexauer mentioned this pull request Sep 24, 2017
Closed
1 task
gfyoung
gfyoung reviewed Sep 24, 2017
View reviewed changes
doc/source/10min.rst
df2.between_time df2.cumprod
df2.bfill df2.cumsum
df2.blocks df2.D
df2.D
Copy link
Member

@gfyoung gfyoung Sep 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened here? So much got deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a bunch out rather than regenerate it. .as_blocks() was in that list

gfyoung
gfyoung reviewed Sep 24, 2017
View reviewed changes
doc/source/whatsnew/v0.21.0.txt Outdated
- :func:`SeriesGroupBy.nth` has deprecated ``True`` in favor of ``'all'`` for its kwarg ``dropna`` (:issue:`11038`).
- :func:`DataFrame.as_blocks` is deprecated as this is exposing the internal implementation (:issue:`17302`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: deprecated --> "deprecated,"

gfyoung
gfyoung reviewed Sep 24, 2017
View reviewed changes
pandas/core/generic.py Outdated
----------
copy : boolean, default True

.. versionadded: 0.16.1
Copy link
Member

@gfyoung gfyoung Sep 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall: were we still keeping versionadded that are this old?

@jreback
Copy link
Contributor Author

jreback commented Sep 24, 2017

update, thanks @gfyoung

@jreback jreback merged commit 868389d into pandas-dev:master Sep 25, 2017
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
@jreback @alanbato
DEPR: deprecate .as_blocks() (pandas-dev#17656)
430ed39 
closes pandas-dev#17302
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@jreback @No-Stream
DEPR: deprecate .as_blocks() (pandas-dev#17656)
7ce4f42 
closes pandas-dev#17302
@jreback jreback mentioned this pull request Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung left review comments

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

DEPR: .as_blocks and .blocks
2 participants
@jreback @gfyoung