Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: passing categories or ordered kwargs to Series.astype is deprecated #17742

Merged
merged 1 commit into from
Oct 3, 2017
Merged

DEPR: passing categories or ordered kwargs to Series.astype is deprecated #17742

merged 1 commit into from
Oct 3, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Oct 2, 2017

closes #17636

@jreback jreback added Categorical Categorical Data Type Deprecate Functionality to remove in pandas labels Oct 2, 2017
@jreback jreback added this to the 0.21.0 milestone Oct 2, 2017
@jsexauer jsexauer mentioned this pull request Oct 2, 2017
Closed
1 task
TomAugspurger
TomAugspurger approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@codecov
Copy link

codecov bot commented Oct 2, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a3d538a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #17742   +/-   ##
=========================================
  Coverage          ?   91.23%           
=========================================
  Files             ?      163           
  Lines             ?    49859           
  Branches          ?        0           
=========================================
  Hits              ?    45490           
  Misses            ?     4369           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.03% <100%> (?)
#single 40.25% <50%> (?)
Impacted Files Coverage Δ
pandas/core/internals.py 94.38% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d538a...cbaa585. Read the comment docs.

@jreback jreback merged commit d944bb9 into pandas-dev:master Oct 3, 2017
@jorisvandenbossche
Copy link
Member

There seem to be still quite some warnings of using this in our own tests, see eg https://travis-ci.org/pandas-dev/pandas/jobs/282520540

ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
@jreback
DEPR: passing categories or ordered kwargs to Series.astype is deprec…
bdb1a3d 
…ated (pandas-dev#17742)

closes pandas-dev#17636
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
@jreback @alanbato
DEPR: passing categories or ordered kwargs to Series.astype is deprec…
b9faef1 
…ated (pandas-dev#17742)

closes pandas-dev#17636
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@jreback @No-Stream
DEPR: passing categories or ordered kwargs to Series.astype is deprec…
cbf60c6 
…ated (pandas-dev#17742)

closes pandas-dev#17636
@jreback jreback mentioned this pull request Jun 30, 2019
Closed
@TomAugspurger TomAugspurger mentioned this pull request Jul 3, 2019
Closed
This was referenced Jun 12, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

DEPR: .astype(..., categories=)
3 participants
@jreback @jorisvandenbossche @TomAugspurger