Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Local conftest for test_offsets.py #17825

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

GuessWhoSamFoo
Copy link
Contributor

  • closes xxxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Continued from #17622 per comments. Looks like offset_types property can be replaced entirely with a fixture.

@codecov
Copy link

codecov bot commented Oct 9, 2017

Codecov Report

Merging #17825 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17825      +/-   ##
==========================================
- Coverage   91.26%   91.22%   -0.05%     
==========================================
  Files         163      163              
  Lines       49980    49980              
==========================================
- Hits        45613    45592      -21     
- Misses       4367     4388      +21
Flag Coverage Δ
#multiple 89.02% <100%> (-0.03%) ⬇️
#single 40.24% <100%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/tests/tseries/conftest.py 96.77% <100%> (ø)
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.38% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.74% <0%> (-0.1%) ⬇️
pandas/tests/indexes/conftest.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0ee53...69db510. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 9, 2017

Codecov Report

Merging #17825 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17825      +/-   ##
==========================================
- Coverage   91.26%   91.22%   -0.05%     
==========================================
  Files         163      163              
  Lines       49980    49980              
==========================================
- Hits        45613    45592      -21     
- Misses       4367     4388      +21
Flag Coverage Δ
#multiple 89.02% <100%> (-0.03%) ⬇️
#single 40.24% <100%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/tests/tseries/conftest.py 96.77% <100%> (ø)
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.38% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.74% <0%> (-0.1%) ⬇️
pandas/tests/indexes/conftest.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0ee53...69db510. Read the comment docs.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Oct 9, 2017
@jreback jreback added this to the 0.21.0 milestone Oct 9, 2017
@jreback jreback merged commit f57071a into pandas-dev:master Oct 9, 2017
@jreback
Copy link
Contributor

jreback commented Oct 9, 2017

thanks!

keem em coming!

ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
@GuessWhoSamFoo GuessWhoSamFoo deleted the tseries_offsets_fixture branch October 27, 2017 06:38
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants