BUG: Fix to_latex with longtable (#17959) #17960

syxolk · 2017-10-23T20:43:52Z

closes to_latex wrong \multicolumn count #17959
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

pandas.DataFrame.to_latex(longtable=True) always contained \multicolumn{3}{r}{{Continued on next page}} regardless of the number of columns in the output. This is now changed to use the actual number of columns in the output.

codecov · 2017-10-23T22:16:42Z

Codecov Report

Merging #17960 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #17960      +/-   ##
==========================================
- Coverage    91.6%   91.58%   -0.02%     
==========================================
  Files         153      153              
  Lines       51306    51306              
==========================================
- Hits        46998    46990       -8     
- Misses       4308     4316       +8

Flag	Coverage Δ
#multiple	`89.44% <100%> (ø)`	⬆️
#single	`40.72% <0%> (-0.12%)`	⬇️

Impacted Files	Coverage Δ
pandas/io/formats/format.py	`96.17% <100%> (+0.14%)`	⬆️
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/frame.py	`97.81% <0%> (-0.1%)`	⬇️
pandas/core/indexes/datetimes.py	`95.59% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae74c2b...930471d. Read the comment docs.

gfyoung · 2017-10-24T18:55:41Z

@syxolk : You just need a whatsnew entry, and this should be good to go.

syxolk · 2017-10-25T00:40:40Z

I just added the whatsnew entry and squashed the commits.

gfyoung · 2017-10-25T01:37:44Z

@syxolk : That's great! @jreback PTAL

jreback · 2017-10-25T10:35:37Z

pandas/tests/io/formats/test_to_latex.py

@@ -365,7 +365,7 @@ def test_to_latex_longtable(self, frame):
 \midrule
 \endhead
 \midrule
-\multicolumn{3}{r}{{Continued on next page}} \\


can you make sure we are testing for 0, 1, 2, 3 columns (you don't have to fully compare the output, just assert that the multicolumn directive is correct)

Just added test cases for 1 and 3 columns. We already had a test case with 2 columns. I don't think tables with 0 columns make any sense. What do you think?

sure they do, an empty dataframe is possible

@jreback : The code has a deliberate short-circuit for an empty DataFrame, and this pattern will not be followed for 0 columns in fact. I added a couple of tests for that short-circuit.

jreback · 2017-11-07T17:55:51Z

doc/source/whatsnew/v0.21.0.txt

@@ -998,6 +998,7 @@ I/O
 - Bug in :meth:`DataFrame.to_html` in which there was no validation of the ``justify`` parameter (:issue:`17527`)
 - Bug in :func:`HDFStore.select` when reading a contiguous mixed-data table featuring VLArray (:issue:`17021`)
 - Bug in :func:`to_json` where several conditions (including objects with unprintable symbols, objects with deep recursion, overlong labels) caused segfaults instead of raising the appropriate exception (:issue:`14256`)
+- Bug in :meth:`DataFrame.to_latex` with ``longtable=True`` where a latex multicolumn always spanned over three columns (:issue:`17959`)



move to 0.21.1

jreback · 2017-11-25T16:23:17Z

can you rebase & update

jreback · 2017-12-08T02:22:55Z

can you update?

gfyoung · 2017-12-08T02:29:06Z

@jreback : I can carry this to the finish line.

syxolk · 2017-12-10T00:43:51Z

@jreback : I can carry this to the finish line.

Thanks! Sorry, I was quite busy.

pandas.DataFrame.to_latex(longtable=True) always contained \multicolumn{3}{r}{{Continued on next page}} regardless of the number of columns in the output.

* Move whatsnew to 0.21.1.txt * Empty tests for empty DataFrame in to_latex

gfyoung · 2017-12-11T08:24:27Z

@jreback : All changes have been addressed. PTAL.

jreback · 2017-12-11T11:08:45Z

thanks @syxolk @gfyoung

closes pandas-dev#17959 (cherry picked from commit e909ea0)

closes #17959 (cherry picked from commit e909ea0)

A vestige of gh-17960. Should have been removed before merge.

Version 0.22.0 * tag 'v0.22.0': (777 commits) RLS: v0.22.0 DOC: Fix min_count docstring (pandas-dev#19005) DOC: More 0.22.0 updates (pandas-dev#19002) TST: Remove pow test in expressions COMPAT: Avoid td.skip decorator DOC: 0.22.0 release docs (pandas-dev#18983) DOC: Include 0.22.0 whatsnew Breaking changes for sum / prod of empty / all-NA (pandas-dev#18921) ENH: Added a min_count keyword to stat funcs (pandas-dev#18876) RLS: v0.21.1 DOC: Add date to whatsnew (pandas-dev#18740) DOC: Include 0.21.1 whatsnew DOC: Update relase notes (pandas-dev#18739) CFG: Ignore W503 DOC: fix options table (pandas-dev#18730) ENH: support non default indexes in writing to Parquet (pandas-dev#18629) BUG: Fix to_latex with longtable (pandas-dev#17959) (pandas-dev#17960) Parquet: Add error message for no engine found (pandas-dev#18717) BUG: Categorical data fails to load from hdf when all columns are NaN (pandas-dev#18652) DOC: clean-up whatsnew file for 0.21.1 (pandas-dev#18690) ...

* releases: (777 commits) RLS: v0.22.0 DOC: Fix min_count docstring (pandas-dev#19005) DOC: More 0.22.0 updates (pandas-dev#19002) TST: Remove pow test in expressions COMPAT: Avoid td.skip decorator DOC: 0.22.0 release docs (pandas-dev#18983) DOC: Include 0.22.0 whatsnew Breaking changes for sum / prod of empty / all-NA (pandas-dev#18921) ENH: Added a min_count keyword to stat funcs (pandas-dev#18876) RLS: v0.21.1 DOC: Add date to whatsnew (pandas-dev#18740) DOC: Include 0.21.1 whatsnew DOC: Update relase notes (pandas-dev#18739) CFG: Ignore W503 DOC: fix options table (pandas-dev#18730) ENH: support non default indexes in writing to Parquet (pandas-dev#18629) BUG: Fix to_latex with longtable (pandas-dev#17959) (pandas-dev#17960) Parquet: Add error message for no engine found (pandas-dev#18717) BUG: Categorical data fails to load from hdf when all columns are NaN (pandas-dev#18652) DOC: clean-up whatsnew file for 0.21.1 (pandas-dev#18690) ...

jreback added the IO LaTeX to_latex label Oct 23, 2017

gfyoung added the Bug label Oct 23, 2017

syxolk force-pushed the fix-issue-17959-to-latex-longtable branch from b3eccbc to 7a71573 Compare October 25, 2017 00:36

gfyoung approved these changes Oct 25, 2017

View reviewed changes

jreback requested changes Oct 25, 2017

View reviewed changes

jreback requested changes Nov 7, 2017

View reviewed changes

gfyoung self-assigned this Dec 8, 2017

gfyoung force-pushed the fix-issue-17959-to-latex-longtable branch from 23fc5d3 to 324b780 Compare December 8, 2017 05:45

syxolk added 2 commits December 10, 2017 17:28

BUG: Fix to_latex with longtable (pandas-dev#17959)

6cd4145

pandas.DataFrame.to_latex(longtable=True) always contained \multicolumn{3}{r}{{Continued on next page}} regardless of the number of columns in the output.

Add test cases with 1 and 3 columns

60a4fc8

gfyoung force-pushed the fix-issue-17959-to-latex-longtable branch 2 times, most recently from 677a27d to 9b4d30e Compare December 11, 2017 03:29

MAINT: Address reviewer comments

930471d

* Move whatsnew to 0.21.1.txt * Empty tests for empty DataFrame in to_latex

gfyoung force-pushed the fix-issue-17959-to-latex-longtable branch from 9b4d30e to 930471d Compare December 11, 2017 03:30

jreback added this to the 0.21.1 milestone Dec 11, 2017

jreback approved these changes Dec 11, 2017

View reviewed changes

jreback merged commit e909ea0 into pandas-dev:master Dec 11, 2017

jreback added the Needs Backport label Dec 11, 2017

gfyoung removed their assignment Dec 11, 2017

TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 11, 2017

BUG: Fix to_latex with longtable (pandas-dev#17959) (pandas-dev#17960)

620048b

closes pandas-dev#17959 (cherry picked from commit e909ea0)

TomAugspurger pushed a commit that referenced this pull request Dec 12, 2017

BUG: Fix to_latex with longtable (#17959) (#17960)

adf796a

closes #17959 (cherry picked from commit e909ea0)

TomAugspurger removed the Needs Backport label Dec 12, 2017

gfyoung added a commit that referenced this pull request Dec 15, 2017

MAINT: Remove write to .txt file in to_latex test

0303d0d

A vestige of gh-17960. Should have been removed before merge.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG: Fix to_latex with longtable (#17959) #17960

BUG: Fix to_latex with longtable (#17959) #17960

syxolk commented Oct 23, 2017 •

edited

Loading

codecov bot commented Oct 23, 2017 •

edited

Loading

gfyoung commented Oct 24, 2017

syxolk commented Oct 25, 2017

gfyoung commented Oct 25, 2017

jreback Oct 25, 2017

syxolk Nov 7, 2017

jreback Nov 7, 2017

gfyoung Dec 8, 2017

jreback Nov 7, 2017

gfyoung Dec 8, 2017

jreback commented Nov 25, 2017

jreback commented Dec 8, 2017

gfyoung commented Dec 8, 2017

syxolk commented Dec 10, 2017

gfyoung commented Dec 11, 2017

jreback commented Dec 11, 2017

BUG: Fix to_latex with longtable (#17959) #17960

BUG: Fix to_latex with longtable (#17959) #17960

Conversation

syxolk commented Oct 23, 2017 • edited Loading

codecov bot commented Oct 23, 2017 • edited Loading

Codecov Report

gfyoung commented Oct 24, 2017

syxolk commented Oct 25, 2017

gfyoung commented Oct 25, 2017

jreback Oct 25, 2017

Choose a reason for hiding this comment

syxolk Nov 7, 2017

Choose a reason for hiding this comment

jreback Nov 7, 2017

Choose a reason for hiding this comment

gfyoung Dec 8, 2017

Choose a reason for hiding this comment

jreback Nov 7, 2017

Choose a reason for hiding this comment

gfyoung Dec 8, 2017

Choose a reason for hiding this comment

jreback commented Nov 25, 2017

jreback commented Dec 8, 2017

gfyoung commented Dec 8, 2017

syxolk commented Dec 10, 2017

gfyoung commented Dec 11, 2017

jreback commented Dec 11, 2017

syxolk commented Oct 23, 2017 •

edited

Loading

codecov bot commented Oct 23, 2017 •

edited

Loading