Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "DOC: Remove vendored IPython.sphinext (#18193)" #18320

Merged

Conversation

jorisvandenbossche
Copy link
Member

This reverts commit ca737ac.

This reverts #18193. The problem is there is something wrong with the upstream version such that errors in the code don't get reported.

@codecov
Copy link

codecov bot commented Nov 16, 2017

Codecov Report

Merging #18320 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18320      +/-   ##
==========================================
- Coverage   91.39%   91.37%   -0.02%     
==========================================
  Files         164      164              
  Lines       49808    49808              
==========================================
- Hits        45520    45511       -9     
- Misses       4288     4297       +9
Flag Coverage Δ
#multiple 89.17% <ø> (ø) ⬆️
#single 39.47% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f2a5e...7f1cc25. Read the comment docs.

@jorisvandenbossche
Copy link
Member Author

@TomAugspurger I identified the source of the problem: ipython/ipython#9823 So another option is to pin IPython to an older version (although I would maybe rather vendor the latest upstream version + bug fix, to mimic that we are using the latest IPython version)

@jorisvandenbossche
Copy link
Member Author

I opened an issue at IPython: ipython/ipython#10904 (with potential solution)

@jreback jreback added the Docs label Nov 16, 2017
@TomAugspurger
Copy link
Contributor

Thanks for tracking it down @jorisvandenbossche. I think reverting ca737ac for now is fine. And then once the next IPython is released with your fix, we'd require it for building the docs.

@jorisvandenbossche jorisvandenbossche merged commit d6049a0 into pandas-dev:master Nov 17, 2017
@jorisvandenbossche jorisvandenbossche added this to the 0.22.0 milestone Nov 17, 2017
@jorisvandenbossche jorisvandenbossche deleted the revert-ipython branch February 12, 2018 12:39
jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants