CLN: Drop the skip_footer parameter in read_csv #18724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18724 +/- ##
==========================================
+ Coverage 91.6% 91.6% +<.01%
==========================================
Files 153 153
Lines 51306 51304 -2
==========================================
- Hits 46998 46997 -1
+ Misses 4308 4307 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18724 +/- ##
==========================================
- Coverage 91.61% 91.6% -0.01%
==========================================
Files 153 153
Lines 51339 51304 -35
==========================================
- Hits 47034 46997 -37
- Misses 4305 4307 +2
Continue to review full report at Codecov.
|
jreback
approved these changes
Dec 11, 2017
doc/source/whatsnew/v0.22.0.txt
Outdated
| @@ -218,6 +218,7 @@ Removal of prior version deprecations/changes | |||
| - The ``freq`` and ``how`` parameters have been removed from the ``rolling``/``expanding``/``ewm`` methods of DataFrame | |||
| and Series (deprecated since v0.18). Instead, resample before calling the methods. (:issue:18601 & :issue:18668) | |||
| - ``DatetimeIndex.to_datetime``, ``Timestamp.to_datetime``, ``PeriodIndex.to_datetime``, and ``Index.to_datetime`` have been removed (:issue:`8254`, :issue:`14096`, :issue:`14113`) | |||
| - ``pd.read_csv`` has dropped the ``skip_footer`` parameter (:issue:`13386`) | |||
There was a problem hiding this comment.
you can do :func:`read_csv`
Deprecated back in 0.19.0. xref pandas-devgh-13386.
gfyoung
force-pushed
the
csv-skip-footer-remove
branch
from
be127de
to
cefc2e6
Compare
|
Appveyor failure unrelated to PR (was green before). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated back in 0.19.0.
xref #13386.