CLN: Drop the as_recarray parameter in read_csv #18804
Conversation
Deprecated back in 0.19.0 xref pandas-devgh-13373.
Codecov Report
@@ Coverage Diff @@
## master #18804 +/- ##
==========================================
- Coverage 91.64% 91.62% -0.03%
==========================================
Files 154 154
Lines 51428 51411 -17
==========================================
- Hits 47129 47103 -26
- Misses 4299 4308 +9
Continue to review full report at Codecov.
|
|
Everything is green now. If there are no objections, I'll merge later today. |
|
pls wait for my review |
|
|
||
| recs = sarr_from_data(dt, length, buf) | ||
| assert(recs.flags.owndata) | ||
|
|
There was a problem hiding this comment.
i believe u can remove
sarr_from_data
_fill_structured_columns
from the codebase as well
There was a problem hiding this comment.
we don’t have flake8 on cython that looks for unused things fyi
There was a problem hiding this comment.
Yeah...that's tougher to check, as flake8 works on a file-by-file basis and has no holistic check on the code-base.
There was a problem hiding this comment.
GitHub search seems to agree with your belief though.
Was only used for creating the recarray object.
The function was only used in creating a recarray.
The function was only used in creating a recarray.
|
@jreback : Those two functions have been removed, and all is still green. PTAL. |
|
thanks @gfyoung |
Deprecated back in 0.19.0
xref #13373.