Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove tseries v0.19.0 deprecations #19023

Merged
merged 1 commit into from
Jan 2, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Jan 1, 2018

  • Remove frequencies.get_standard_freq
  • Drop the "freqstr" keyword from frequencies.to_offset

Deprecated in v0.19.0

xref #13874

@gfyoung gfyoung added Clean Deprecate Functionality to remove in pandas labels Jan 1, 2018
@jreback
Copy link
Contributor

jreback commented Jan 1, 2018

rebase and push again, fixed some hanging by Travis CI

* Remove frequencies.get_standard_freq
* Drop the "freqstr" keyword from frequencies.to_offset

Deprecated in v0.19.0

xref pandas-devgh-13874
@gfyoung
Copy link
Member Author

gfyoung commented Jan 1, 2018

@jreback : Surprised master is doing okay. A lot of PR builds on Travis are getting hit with this "disk quota exceeded" error. Seems to be affecting a lot of other repositories though.

@jreback
Copy link
Contributor

jreback commented Jan 1, 2018

@gfyoung that was this morning. I think travis ci is having issues since then.

@gfyoung
Copy link
Member Author

gfyoung commented Jan 1, 2018

It's still happening though AFAICT. The PR build before mine has already failed on two builds with that exact same error.

https://travis-ci.org/pandas-dev/pandas/builds/323891129

@jreback
Copy link
Contributor

jreback commented Jan 1, 2018

see the Travis Status: https://twitter.com/traviscistatus?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor

still happening. FYI this is the Red icon on the travis page

@codecov
Copy link

codecov bot commented Jan 2, 2018

Codecov Report

Merging #19023 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19023      +/-   ##
==========================================
- Coverage   91.57%   91.57%   -0.01%     
==========================================
  Files         150      150              
  Lines       48941    48935       -6     
==========================================
- Hits        44817    44811       -6     
  Misses       4124     4124
Flag Coverage Δ
#multiple 89.93% <ø> (-0.01%) ⬇️
#single 41.75% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/tseries/frequencies.py 93.9% <ø> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c19bdc9...f80c516. Read the comment docs.

@gfyoung
Copy link
Member Author

gfyoung commented Jan 2, 2018

@jreback : Looks like Travis is up and running again. All is green now. PTAL.

@gfyoung gfyoung added this to the 0.23.0 milestone Jan 2, 2018
@jreback jreback merged commit a697421 into pandas-dev:master Jan 2, 2018
@jreback
Copy link
Contributor

jreback commented Jan 2, 2018

thanks!

@gfyoung gfyoung deleted the freq-depr-remove branch January 2, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants