Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: Correct signature for group_nth / group_object #19579

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

TomAugspurger
Copy link
Contributor

Closes #19283

@TomAugspurger TomAugspurger added Groupby Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version labels Feb 7, 2018
@TomAugspurger TomAugspurger added this to the 0.23.0 milestone Feb 7, 2018
@TomAugspurger
Copy link
Contributor Author

From the original issue

In [24]: %timeit msgs.groupby(['date', 'orderid']).first();
44.8 ms ± 2.09 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

vs. ~10s

@codecov
Copy link

codecov bot commented Feb 7, 2018

Codecov Report

Merging #19579 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19579      +/-   ##
==========================================
- Coverage   91.62%   91.62%   -0.01%     
==========================================
  Files         150      150              
  Lines       48773    48773              
==========================================
- Hits        44687    44686       -1     
- Misses       4086     4087       +1
Flag Coverage Δ
#multiple 89.99% <ø> (-0.01%) ⬇️
#single 41.74% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/groupby.py 92.12% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5052842...59f927d. Read the comment docs.

@jreback jreback merged commit 36f9052 into pandas-dev:master Feb 8, 2018
@jreback
Copy link
Contributor

jreback commented Feb 8, 2018

hahah the wonders of calling cython functions, when we catch the non-existing functions!

@TomAugspurger TomAugspurger deleted the groupby-first-perf branch February 8, 2018 02:22
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants