BUG: drop_duplicates not raising KeyError on missing key #19730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #17879 introduced an error by iterating over the columns in the dataframe, not the columns in the subset. This meant that passing in a column name missing from the dataframe would no longer raise a `KeyError` like it had previously. This fix checks the subset first before pulling necessary columns from the dataframe, and raises the necessary `KeyError` when a given column doesn't exist. Fixes #19726
Codecov Report
@@ Coverage Diff @@
## master #19730 +/- ##
==========================================
+ Coverage 91.58% 91.58% +<.01%
==========================================
Files 150 150
Lines 48867 48890 +23
==========================================
+ Hits 44755 44777 +22
- Misses 4112 4113 +1
Continue to review full report at Codecov.
|
jreback
requested changes
Feb 18, 2018
pandas/core/frame.py
Outdated
| @@ -3655,6 +3655,10 @@ def f(vals): | |||
| isinstance(subset, tuple) and subset in self.columns): | |||
| subset = subset, | |||
|
|
|||
| for name in subset: | |||
There was a problem hiding this comment.
can you add a comment here on what you are checking
There was a problem hiding this comment.
you can do this
diff = pd.Index(subset).difference(self.columns)
if len(diff):
raise KeyError(diff)
jreback
added
Indexing
|
can you also check |
|
Updated! |
jreback
approved these changes
Feb 21, 2018
|
thanks! |
NoahTheDuke
deleted the
bugfix-drop_duplicates-when-column-name-misspelled
branch
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17879 introduced an error by iterating over the columns in the dataframe, not the columns in the subset. This meant that passing in a column name missing from the dataframe would no longer raise a
KeyErrorlike it had previously.This fix checks the subset first before pulling necessary columns from the dataframe, and raises the necessary
KeyErrorwhen a given column doesn't exist.