Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC/BLD: Pinning sphinx to 1.5, as 1.7 has been released and it's incompatible with vendored numpydoc #19743

Merged
merged 3 commits into from
Feb 18, 2018

Conversation

datapythonista
Copy link
Member

@jreback jreback added Build Library building on various platforms Docs labels Feb 18, 2018
@jreback jreback added this to the 0.23.0 milestone Feb 18, 2018
@jreback
Copy link
Contributor

jreback commented Feb 18, 2018

thanks

@jreback jreback merged commit c086a51 into pandas-dev:master Feb 18, 2018
@TomAugspurger
Copy link
Contributor

TomAugspurger commented Feb 18, 2018

Ahh this should have gone in environment-dev.yaml and been auto-generated by scripts/convert_deps.py. Can you make another PR @datapythonista?

@jreback
Copy link
Contributor

jreback commented Feb 18, 2018

ahh that's right.

@jorisvandenbossche
Copy link
Member

If the performance problems are solved with Sphinx 1.7, I would rather do the small fix in our vendored numpydoc version instead of keep pinning sphinx to 1.5.
I am trying to test this in #19687, but the problem it keeps installing sphinx 1.6 because it is not yet available on defaults. Will change it temporarily to install from conda-forge to test it.

@jorisvandenbossche
Copy link
Member

Updated the other PR, let's see what it does: https://travis-ci.org/pandas-dev/pandas/jobs/343064791

@jorisvandenbossche
Copy link
Member

I reverted this in #19687, and the last commit there tested sphinx 1.7 on travis, and it ran without failure and without time-out. So it seems we are good for sphinx 1.7.

harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building docs fails with the latest version of sphinx
4 participants