Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtensionArray.take default implementation #20814

Merged
merged 32 commits into from
Apr 27, 2018

Commits on Apr 24, 2018

  1. [WIP]: ExtensionArray.take default implementation

    Implements a take interface that's compatible with NumPy and optionally pandas'
    NA semantics.
    
    ```python
    In [1]: import pandas as pd
    
    In [2]: from pandas.tests.extension.decimal.array import *
    
    In [3]: arr = DecimalArray(['1.1', '1.2', '1.3'])
    
    In [4]: arr.take([0, 1, -1])
    Out[4]: DecimalArray(array(['1.1', '1.2', '1.3'], dtype=object))
    
    In [5]: arr.take([0, 1, -1], fill_value=float('nan'))
    Out[5]: DecimalArray(array(['1.1', '1.2', Decimal('NaN')], dtype=object))
    ```
    
    Closes pandas-dev#20640
    TomAugspurger committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    fb3c234 View commit details
    Browse the repository at this point in the history
  2. Moves

    TomAugspurger committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    dacd98e View commit details
    Browse the repository at this point in the history
  3. non-internals changes

    TomAugspurger committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    0be9ec6 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2018

  1. Fixup JSON take

    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    08f2479 View commit details
    Browse the repository at this point in the history
  2. More internals hacking

    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    eba137f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    67ba9dd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    37915e9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c721915 View commit details
    Browse the repository at this point in the history
  6. Simplify

    Upcasting is still broken
    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    125ca0b View commit details
    Browse the repository at this point in the history
  7. revert combine change

    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    b7ae0bc View commit details
    Browse the repository at this point in the history
  8. Upcasting

    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    338566f View commit details
    Browse the repository at this point in the history
  9. pep8

    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    31cd304 View commit details
    Browse the repository at this point in the history
  10. Updated docs

    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    05d8844 View commit details
    Browse the repository at this point in the history
  11. Updates

    1. Reversed order of take keywords
    2. Added to extensions API
    3. Removed default implementation
    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    69e7fe7 View commit details
    Browse the repository at this point in the history
  12. Linting

    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    449983b View commit details
    Browse the repository at this point in the history
  13. Bounds checking

    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    c449afd View commit details
    Browse the repository at this point in the history
  14. Stale comment

    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    82cad8b View commit details
    Browse the repository at this point in the history
  15. Fixed reorder

    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    d5470a0 View commit details
    Browse the repository at this point in the history
  16. Cleanup

    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    bbcbf19 View commit details
    Browse the repository at this point in the history
  17. Pass an array

    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    1a4d987 View commit details
    Browse the repository at this point in the history
  18. Fixed editor

    TomAugspurger committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    fc729d6 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2018

  1. Added verisonadded

    TomAugspurger committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    74b2c09 View commit details
    Browse the repository at this point in the history
  2. Doc and move tests

    TomAugspurger committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    5db6624 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    741f284 View commit details
    Browse the repository at this point in the history
  4. Updates

    * indexer -> indices
    * doc user-facing vs physical
    * assert na_cmps
    * test reindex w/ non-NA fill_value
    TomAugspurger committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    fbc4425 View commit details
    Browse the repository at this point in the history
  5. doc fixup

    TomAugspurger committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    f3b91ca View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    eecd632 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2018

  1. Doc updates

    TomAugspurger committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    9a6c7d4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7c4f625 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eb43fa4 View commit details
    Browse the repository at this point in the history
  4. Added note

    TomAugspurger committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    6858409 View commit details
    Browse the repository at this point in the history
  5. Updates

    TomAugspurger committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    ec0cecd View commit details
    Browse the repository at this point in the history