-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to_* methods to compression='infer' #22011
Merged
gfyoung
merged 40 commits into
pandas-dev:master
from
dhimmel:default-to-infer-compression
Aug 1, 2018
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
8689167
Default to_csv & to_json to compression='infer'
dhimmel 3ccfb00
to_json compression=infer in pandas/core/generic.py
dhimmel 648bf4d
Simplify CSVFormatter.save
dhimmel be724fa
Exploratory commit of what CSVFormatter.save should look like
dhimmel 9fe27c9
fixup! Simplify CSVFormatter.save
dhimmel 65f0689
"Revert changes not related to compression default
dhimmel 868e671
TST: test to_csv infers compression by default
dhimmel c3b76ee
Debugging print statements
dhimmel cebc0d9
Debugging: use logging rather than print
dhimmel 8411eb2
_infer_compression in CSVFormatter
dhimmel c098c8f
CSVFormatter: process encoding in init for consistency
dhimmel 2f6601d
TST + DOC: test_compression_warning docstring
dhimmel eb7f9b5
fixup! CSVFormatter: process encoding in init for consistency
dhimmel d4a5c90
Tests passing: remove debugging
dhimmel abd19e3
Parametrized test for compression='infer' is default
dhimmel 2f670fe
Default compression='infer' in series.to_csv
dhimmel aa9ce13
What's New Entry for v0.24.0
dhimmel a6aabad
Remove unused tmpdir fixture argument
dhimmel 8a0c97e
Update to_json docstring
dhimmel 6be808d
Change test docstrings to comments
dhimmel 63e6591
Consolidate testing to a single parametrized test
dhimmel fadb943
Split test_compression_defaults_to_infer into Series & DataFrame tests
dhimmel 0edffc7
Parametrize write_kwargs
dhimmel 97f5de5
Fix kwargs in test_series_compression_defaults_to_infer
dhimmel 83bc0a8
Attempt to fix CSV series roundtrip
dhimmel 874a4bf
Fix test failure
dhimmel 14c3945
Python 2 flake8 error
dhimmel 9a4dc41
Reduce / remove comments
dhimmel 25bdb4c
Merge master: fix zip-docs conflict
dhimmel 1ba8f3a
DOC: versionchanged & tweaks
dhimmel 24e051e
Update doc/source/io.rst as needed
dhimmel 387d1d2
Move tests from tests/test_common.py to tests/io/test_common.py
dhimmel 12f14e2
Organize / simplify pandas/tests/test_common.py imports
dhimmel 6db23d9
Ignore flake error needed for test
dhimmel e3a0f56
fixup! Organize / simplify pandas/tests/test_common.py imports
dhimmel af8c137
change import: cmn to icom
dhimmel f8829a6
Blank lines after versionchanged
dhimmel 918c0f8
Move compression tests to new file tests/io/test_compression.py
dhimmel eadf68e
blank lines before .. versionchanged
dhimmel cf5b62e
Remove comments and space after GH
dhimmel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -28,7 +28,7 @@ | |||
# interface to/from | ||||
def to_json(path_or_buf, obj, orient=None, date_format='epoch', | ||||
double_precision=10, force_ascii=True, date_unit='ms', | ||||
default_handler=None, lines=False, compression=None, | ||||
default_handler=None, lines=False, compression='infer', | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure where to update the to_json docs... didn't see a docstring in this function. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Line 1905 in 322dbf4
|
||||
index=True): | ||||
|
||||
if not index and orient not in ['split', 'table']: | ||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add versionchanged in each of the modified doc-strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 1ba8f3a