Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: suppress deprecation warnings for compress #22064

Merged

Conversation

jorisvandenbossche
Copy link
Member

xref #21930 (comment)

In case we find it OK np.compress with Series is also deprecated, this PR makes sure the warnings are catched in the tests.

@jorisvandenbossche jorisvandenbossche added Testing pandas testing functions or related to the test suite Deprecate Functionality to remove in pandas labels Jul 26, 2018
@jorisvandenbossche jorisvandenbossche added this to the 0.24.0 milestone Jul 26, 2018
@TomAugspurger
Copy link
Contributor

Copying from the other PR, how about we update the deprecation message to

Use `series[condition] or np.asarray(series).compress(condition)`

We may also need something that np.compress(series) is also deprecated.

Series.compress and np.compress(series, condition) are deprecated.

Use series[condition] or np.asarray(series).compress(condition) instead.

@jreback
Copy link
Contributor

jreback commented Jul 28, 2018

can you rebase

@jorisvandenbossche
Copy link
Member Author

@TomAugspurger edited the deprecation message

@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #22064 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22064      +/-   ##
==========================================
- Coverage   92.08%   92.05%   -0.04%     
==========================================
  Files         169      169              
  Lines       50691    50709      +18     
==========================================
- Hits        46681    46679       -2     
- Misses       4010     4030      +20
Flag Coverage Δ
#multiple 90.46% <100%> (-0.04%) ⬇️
#single 42.25% <0%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/series.py 93.72% <100%> (-0.4%) ⬇️
pandas/core/internals/blocks.py 93.83% <0%> (-0.81%) ⬇️
pandas/core/dtypes/missing.py 92.98% <0%> (-0.59%) ⬇️
pandas/util/testing.py 85.85% <0%> (-0.21%) ⬇️
pandas/core/generic.py 96.44% <0%> (-0.04%) ⬇️
pandas/core/frame.py 97.24% <0%> (-0.01%) ⬇️
pandas/plotting/_core.py 83.48% <0%> (ø) ⬆️
pandas/core/indexes/multi.py 95.41% <0%> (+0.07%) ⬆️
pandas/core/ops.py 96.71% <0%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 188a4fc...753929d. Read the comment docs.

@jorisvandenbossche jorisvandenbossche merged commit 2a2d1cf into pandas-dev:master Aug 15, 2018
@jorisvandenbossche jorisvandenbossche deleted the compress-test branch August 15, 2018 08:06
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants