~Finish collecting m8[ns] tests, start collecting division by zero tests #22153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etic, parametrize more
|
k, rebase on top as merged #22074 |
Codecov Report
@@ Coverage Diff @@
## master #22153 +/- ##
==========================================
+ Coverage 92.06% 92.06% +<.01%
==========================================
Files 169 169
Lines 50694 50694
==========================================
+ Hits 46671 46672 +1
+ Misses 4023 4022 -1
Continue to review full report at Codecov.
|
|
One build is failing because it says there is no "box" fixture, but there is. Seen this before? |
|
@jreback this should go before others for easiest rebasing |
|
ok lgtm. can you rebase and merge on green (just to make sure). can you make the next followup to split this to a sub-dir (i know its all td atm but just to make it clear / easier) |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
…sts (pandas-dev#22153) * implement box fixture, move a couple tests from timedelta.test_arithmetic, parametrize more * port floordiv tests * port test_td64arr_rfloordiv_tdlike_scalar * make fixtures, port last of TimedeltaIndex div/mul tests * port add/sub tests, cleanup imports * port test_tdi_add_offset-index * port offset addsub tests * start collecting division by zero tests * dummy commit to force CI * fix dumb name override mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The division by zero tests aren't yet parametrized, are mostly just moved as-is. Both these and the newly moved m8[ns] tests will need a bunch of de-duplication in the next pass.
Tons of DataFrame tests failing. #22074 is the PR we need, though maybe not the one we deserve.
Started in on fixtures.