Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: updating the Series.str.cat docstring #22175

Merged
merged 1 commit into from
Aug 2, 2018
Merged

DOC: updating the Series.str.cat docstring #22175

merged 1 commit into from
Aug 2, 2018

Conversation

ym-pett
Copy link
Contributor

@ym-pett ym-pett commented Aug 2, 2018 •
edited
Loading

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@amblina
Copy link

amblina commented Aug 2, 2018

We have run validate_docstrings.py and gotten the following error:

Errors found:
  Errors in parameters section
       Parameter "join" description should finish with "."

This is nothing to do with our PR. We're great.

@Cheukting
Copy link
Contributor

I think the error is because the "." is followed by "other" @datapythonista may be you can varify

@TomAugspurger
Copy link
Contributor

Pretty sure that error is from the .. versionadded:: . We need to update the script to not complain when there isn't an ending period for those.

@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Aug 2, 2018
@TomAugspurger TomAugspurger merged commit 7725fa0 into pandas-dev:master Aug 2, 2018
@TomAugspurger
Copy link
Contributor

Thanks!

dberenbaum pushed a commit to dberenbaum/pandas that referenced this pull request Aug 3, 2018
@ym-pett @dberenbaum
DOC: added .join to 'see also' in Series.str.cat (pandas-dev#22175)
fce9f57
minggli added a commit to minggli/pandas that referenced this pull request Aug 5, 2018
@minggli
merge master
fa1a1e5 
* master: (47 commits)
  Run tests in conda build [ci skip] (pandas-dev#22190)
  TST: Check DatetimeIndex.drop on DST boundary (pandas-dev#22165)
  CI: Fix Travis failures due to lint.sh on pandas/core/strings.py (pandas-dev#22184)
  Documentation: typo fixes in MultiIndex / Advanced Indexing (pandas-dev#22179)
  DOC: added .join to 'see also' in Series.str.cat (pandas-dev#22175)
  DOC: updated Series.str.contains see also section (pandas-dev#22176)
  0.23.4 whatsnew (pandas-dev#22177)
  fix: scalar timestamp assignment (pandas-dev#19843) (pandas-dev#19973)
  BUG: Fix get dummies unicode error (pandas-dev#22131)
  Fixed py36-only syntax [ci skip] (pandas-dev#22167)
  DEPR: pd.read_table (pandas-dev#21954)
  DEPR: Removing previously deprecated datetools module (pandas-dev#6581) (pandas-dev#19119)
  BUG: Matplotlib scatter datetime (pandas-dev#22039)
  CLN: Use public method to capture UTC offsets (pandas-dev#22164)
  implement tslibs/src to make tslibs self-contained (pandas-dev#22152)
  Fix categorical from codes nan 21767 (pandas-dev#21775)
  BUG: Better handling of invalid na_option argument for groupby.rank(pandas-dev#22124) (pandas-dev#22125)
  use memoryviews instead of ndarrays (pandas-dev#22147)
  Remove depr. warning in SeriesGroupBy.count (pandas-dev#22155)
  API: Default to_* methods to compression='infer' (pandas-dev#22011)
  ...
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@ym-pett
DOC: added .join to 'see also' in Series.str.cat (pandas-dev#22175)
c81c63b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ym-pett @amblina @Cheukting @TomAugspurger