Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add set_index to Series #22225
ENH: Add set_index to Series #22225
Changes from 13 commits
3e968a5
26723ac
d9d9f45
8f5ed33
6cf3ac1
4358d52
b89af70
f17eb7e
5e49884
bb8df65
e4d3698
f8fa20a
ac4cadb
2428e09
31b5990
aaa8644
81cfd82
7f35d2c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not duplicating the - different - checks from
Series.set_index
andDataFrame.set_index
here - is there any chance that someone callsNDFrame.set_index
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What case does the first condition handle here? I'm having trouble finding a case where
Series.set_index([foo])
butSeries.set_index(foo)
doesn't (or wouldn't without the[]
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomAugspurger
The first condition makes sure the second one can execute (i.e. iteration). If it is not true and we end up wrapping it in a list, it will fail in the next step.
The point that is crucial though is that only lists are affected by this (and not all list-likes), because
NDFrame.set_index
would try to interpret a list of scalars as a list of keys.In any case, I added some comments to clarify this behaviour.